fix config file order

Fix order of config files which was added previously in wrong order.
Local config must have highest precedence, and system config lowest.

Author: thorsten-klein

src/west/configuration.py

@@ -185,10 +185,10 @@ def __init__(self, topdir: PathType | None = None):
 
     def get_paths(self, location: ConfigFile = ConfigFile.ALL) -> list[Path]:
         ret = []
-        if self._global and location in [ConfigFile.GLOBAL, ConfigFile.ALL]:
-            ret.append(self._global.path)
         if self._system and location in [ConfigFile.SYSTEM, ConfigFile.ALL]:
             ret.append(self._system.path)
+        if self._global and location in [ConfigFile.GLOBAL, ConfigFile.ALL]:
+            ret.append(self._global.path)
         if self._local and location in [ConfigFile.LOCAL, ConfigFile.ALL]:
             ret.append(self._local.path)
         return ret

tests/test_config.py

@@ -139,16 +139,16 @@ def test_config_list_paths():
     assert (
         stdout.splitlines()
         == textwrap.dedent(f'''\
-        {WEST_CONFIG_GLOBAL}
         {WEST_CONFIG_SYSTEM}
+        {WEST_CONFIG_GLOBAL}
         {WEST_CONFIG_LOCAL}
         ''').splitlines()
     )
 
     # do not list any configs if no config files currently exist
     # (Note: even no local config exists, same as outside any west workspace)
-    pathlib.Path(WEST_CONFIG_GLOBAL).unlink()
     pathlib.Path(WEST_CONFIG_SYSTEM).unlink()
+    pathlib.Path(WEST_CONFIG_GLOBAL).unlink()
     pathlib.Path(WEST_CONFIG_LOCAL).unlink()
     stdout = cmd('config --list-paths')
     assert stdout.splitlines() == []