Can not add project alongside .west folder

[chirambaht]

I am having trouble with a project of mine. I was using west v1.2.0, and when I upgraded to v1.3.0 (up to v1.5.0 as well), I found that I could not run west update. Here is my project structure:

project
├── app
│   └── west.yml
├── support_repo_1
├── support_repo_2
├── support_repo_3
└── .west
    └── config

I would want to clone a repo to the project folder but west wont allow me to have something like this in my manifest:

    - name: support_repo
    path: .
    revision: support_repo_4
    url: git@github.com:support_4.git

Is there something that I am missing in all of this. I was following the release notes which reference this MR: #754 and this Issue: #102

[pdgendt]

Not sure I follow, but a project can't be cloned to the workspace directory, if that is what you're trying?

[chirambaht]

we run the following command to init our project:

west init -m application_repo_url project

This will create the folder structure that I presented in the original issue ticket.
@pdgendt

[marc-hb]

Can you share an error message and more detailed reproduction steps? Even better: a sample manifest that reproduces.

BTW:

• doc: the west workspace topdir is not a git repository zephyr#84337 /
  zephyrproject-rtos/zephyr@7d40091

[chirambaht]

Here is the error I am receiving running west v1.5.0:

Traceback (most recent call last):
  File "/opt/python/venv/bin/west", line 7, in <module>
    sys.exit(main())
             ^^^^^^
  File "/opt/python/venv/lib/python3.12/site-packages/west/app/main.py", line 1199, in main
    app.run(argv or sys.argv[1:])
  File "/opt/python/venv/lib/python3.12/site-packages/west/app/main.py", line 269, in run
    self.load_manifest()
  File "/opt/python/venv/lib/python3.12/site-packages/west/app/main.py", line 288, in load_manifest
    self.manifest = Manifest.from_topdir(topdir=self.topdir,
                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/venv/lib/python3.12/site-packages/west/manifest.py", line 1238, in from_topdir
    return Manifest(topdir=topdir, config=config,
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/venv/lib/python3.12/site-packages/west/manifest.py", line 1541, in __init__
    self._load_validated()
  File "/opt/python/venv/lib/python3.12/site-packages/west/manifest.py", line 2021, in _load_validated
    self._load_projects(manifest_data, url_bases, defaults)
  File "/opt/python/venv/lib/python3.12/site-packages/west/manifest.py", line 2310, in _load_projects
    project = self._load_project(pd, url_bases, defaults)
              ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/opt/python/venv/lib/python3.12/site-packages/west/manifest.py", line 2460, in _load_project
    if Path(ret_norm).parts[0] == util.WEST_DIR:
       ~~~~~~~~~~~~~~~~~~~~^^^
IndexError: tuple index out of range

In the way of a sample west, here is something that could work:

manifest:
  version: 1.2

  projects:
    - name: zephyr
      url: https://github.com/zephyrproject-rtos/zephyr.git
      revision: main
      clone-depth: 10
      import:
        file: west.yml
        path-prefix: deps
        name-allowlist:
          - mcuboot
          - mbedtls

    - name: memfault-firmware-sdk
      path: .
      revision: 1.33.0
      url: https://github.com/memfault/memfault-firmware-sdk.git

  self:
    path: app

I'm using Memfault as an example of this problem (I am aware that this is not where one would want to add Memfault).

[marc-hb]

Thanks for the details, very useful.

    - name: memfault-firmware-sdk
      path: .

The error message should be MUCH better (so we probably want to leave this issue open to fix the error message) but I believe this is an example of this unsupported configuration:

• doc: the west workspace topdir is not a git repository zephyr#84337

Do you agreed 84337 describes this situation accurately?

I'm sorry it used to work with 1.2.0 and not anymore.

[marc-hb]

I just reproduced with the given manifest, it's perfect thank you. I confirm it broke somewhere in 1.3.

The error message should be MUCH better (so we probably want to leave this issue open to fix the error message)

We really want to keep this open because even west -h throws this stack trace after west init. Definitely not a good user experience.

[chirambaht]

Thanks for the details, very useful.

    - name: memfault-firmware-sdk
      path: .

The error message should be MUCH better (so we probably want to leave this issue open to fix the error message) but I believe this is an example of this unsupported configuration:

• doc: the west workspace topdir is not a git repository zephyr#84337

Do you agreed 84337 describes this situation accurately?

I'm sorry it used to work with 1.2.0 and not anymore.

Indeed that PR is representative of what we are facing.

[marc-hb]

This is enough to reproduce:

manifest:
  version: 1.2

  projects:
    # Something "normal"
    - name: mbedtls
      url: https://github.com/zephyrproject-rtos/mbedtls

    - name: unsupported_topdir
      path: .
      url: https://github.com/memfault/memfault-firmware-sdk.git

[marc-hb]

Please try tentative fix:

• manifest: restore "path: ." ability but with a warning #911

[chirambaht]

Please try tentative fix:

• manifest: restore "path: ." ability but with a warning #911

Tested this and found that it solves the problem and shows the warning succesfully.