ci: Only try to push to s3 for same-repo pull requests #110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When running CI on pull requests, the S3 keys needed to push doc changes are only accessible when the pull request comes from the same repo as the project repo. If it is from a clone, these are not available, and the push fails. Work around this by correctly detecting this case, and avoiding the s3 push in these instances. As we get more and more outside contributions, this will need to be revisited, possibly with a separate workflow that runs in a different context and has the keys available. Signed-off-by: David Brown <[email protected]>
cfriedt
approved these changes
Jun 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running CI on pull requests, the S3 keys needed to push doc changes are only accessible when the pull request comes from the same repo as the project repo. If it is from a clone, these are not available, and the push fails.
Work around this by correctly detecting this case, and avoiding the s3 push in these instances.
As we get more and more outside contributions, this will need to be revisited, possibly with a separate workflow that runs in a different context and has the keys available.