drivers: pinctrl: eos_s3: fix logical OR in pinctrl_eos_s3_configure_pin

kartben · dkalowsk · commit e10904eb3c5b · 2025-06-13T15:37:30.000-07:00
Fix incorrect use of bitwise OR operator when checking pull-up and
pull-down resistor configuration.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/pinctrl/pinctrl_eos_s3.c b/drivers/pinctrl/pinctrl_eos_s3.c
@@ -103,7 +103,7 @@ static int pinctrl_eos_s3_configure_pin(const pinctrl_soc_pin_t *pin)
 	WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, 0);
 	if (pin->high_impedance) {
 		WRITE_BIT(reg_value, PAD_PULL_UP_BIT, 0);
-	} else if (pin->pull_up | pin->pull_down) {
+	} else if (pin->pull_up || pin->pull_down) {
 		WRITE_BIT(reg_value, PAD_PULL_UP_BIT, pin->pull_up);
 		WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, pin->pull_down);
 	}

Original file line number	Diff line number	Diff line change
`@@ -103,7 +103,7 @@ static int pinctrl_eos_s3_configure_pin(const pinctrl_soc_pin_t *pin)`
`103`	`103`	`WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, 0);`
`104`	`104`	`if (pin->high_impedance) {`
`105`	`105`	`WRITE_BIT(reg_value, PAD_PULL_UP_BIT, 0);`
`106`		`- } else if (pin->pull_up \| pin->pull_down) {`
	`106`	`+ } else if (pin->pull_up \|\| pin->pull_down) {`
`107`	`107`	`WRITE_BIT(reg_value, PAD_PULL_UP_BIT, pin->pull_up);`
`108`	`108`	`WRITE_BIT(reg_value, PAD_PULL_DOWN_BIT, pin->pull_down);`
`109`	`109`	`}`