Skip to content

Commit 003fb88

Browse files
kylebonnicikartben
authored andcommitted
scripts: footprint: fix node size computation
fix issue with (no paths) != sum(<no paths>) In some cases it was observed that item were being added to the node_no_paths and these only had a path of ':' hence no node was ever added. This resulted in the size of (no paths) to not be equal to the sum of it's children. I am not sure if this size should be a child named of no paths or if this should be part of the node_hidden_syms. I assumed it should be part of node_hidden_syms Signed-off-by: Kyle Micallef Bonnici <[email protected]>
1 parent f59a054 commit 003fb88

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

scripts/footprint/size_report

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -735,6 +735,7 @@ def generate_any_tree(symbol_dict, total_size, path_prefix):
735735
# Need to account for code and data where there are not emitted
736736
# symbols associated with them.
737737
node_hidden_syms = TreeNode('(hidden)', "(hidden)", parent=root)
738+
node_no_paths._size = sum_node_children_size(node_no_paths)
738739
node_hidden_syms._size = root._size - sum_node_children_size(root)
739740

740741
return root

0 commit comments

Comments
 (0)