gpio: Fix gpio_manage_callback() logic

finikorg · fabiobaltieri · commit 005a4d8a318b · 2022-10-04T14:10:05.000Z
gpio_manage_callback() returns -EINVAL if it could not remove
callback. However if the list is empty success is returned when trying
to remove callback.

Signed-off-by: Andrei Emeltchenko &lt;andrei.emeltchenko@intel.com&gt;
diff --git a/drivers/gpio/gpio_utils.h b/drivers/gpio/gpio_utils.h
@@ -51,6 +51,8 @@ static inline int gpio_manage_callback(sys_slist_t *callbacks,
 				return -EINVAL;
 			}
 		}
+	} else if (!set) {
+		return -EINVAL;
 	}
 
 	if (set) {

Original file line number	Diff line number	Diff line change
`@@ -51,6 +51,8 @@ static inline int gpio_manage_callback(sys_slist_t *callbacks,`
`51`	`51`	`return -EINVAL;`
`52`	`52`	`}`
`53`	`53`	`}`
	`54`	`+ } else if (!set) {`
	`55`	`+ return -EINVAL;`
`54`	`56`	`}`
`55`	`57`
`56`	`58`	`if (set) {`