drivers: gpio: Fixed pin number check condition

udivya73 · nashif · commit 04b885d4e37a · 2021-05-07T09:45:50.000-04:00
Fixed check condition for GPIO pin number.
This check is done
before reading or writing value for the pin.

Verified on ehl_crb.

Signed-off-by: U Divya &lt;u.divya@intel.com&gt;
diff --git a/drivers/gpio/gpio_intel.c b/drivers/gpio/gpio_intel.c
@@ -406,7 +406,7 @@ static int port_get_raw(const struct device *dev, uint32_t mask,
 	while (mask != 0U) {
 		pin = find_lsb_set(mask) - 1;
 
-		if (pin > cfg->num_pins) {
+		if (pin >= cfg->num_pins) {
 			break;
 		}
 
@@ -439,7 +439,7 @@ static int port_set_raw(const struct device *dev, uint32_t mask,
 	while (mask != 0) {
 		pin = find_lsb_set(mask) - 1;
 
-		if (pin > cfg->num_pins) {
+		if (pin >= cfg->num_pins) {
 			break;
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -406,7 +406,7 @@ static int port_get_raw(const struct device *dev, uint32_t mask,`
`406`	`406`	`while (mask != 0U) {`
`407`	`407`	`pin = find_lsb_set(mask) - 1;`
`408`	`408`
`409`		`- if (pin > cfg->num_pins) {`
	`409`	`+ if (pin >= cfg->num_pins) {`
`410`	`410`	`break;`
`411`	`411`	`}`
`412`	`412`
`@@ -439,7 +439,7 @@ static int port_set_raw(const struct device *dev, uint32_t mask,`
`439`	`439`	`while (mask != 0) {`
`440`	`440`	`pin = find_lsb_set(mask) - 1;`
`441`	`441`
`442`		`- if (pin > cfg->num_pins) {`
	`442`	`+ if (pin >= cfg->num_pins) {`
`443`	`443`	`break;`
`444`	`444`	`}`
`445`	`445`