drivers: can: fix can_configure() when CAN-FD is enabled

henrikbrixandersen · cfriedt · commit 05318b5349db · 2021-12-09T20:01:00.000-05:00
Currently, can_configure() pass a hard-coded 0 for the data bitrate (which is only used for CAN-FD), breaking this API for CAN-FD enabled applications. Instead pass in the provided bitrate for both arbitration phase and data phase. Fixes: #34375 Signed-off-by: Henrik Brix Andersen <hebad@vestas.com>
diff --git a/include/drivers/can.h b/include/drivers/can.h
@@ -817,7 +817,7 @@ static inline int can_configure(const struct device *dev, enum can_mode mode,
 				uint32_t bitrate)
 {
 	if (bitrate > 0) {
-		int err = can_set_bitrate(dev, bitrate, 0);
+		int err = can_set_bitrate(dev, bitrate, bitrate);
 		if (err != 0) {
 			return err;
 		}
@@ -826,7 +826,6 @@ static inline int can_configure(const struct device *dev, enum can_mode mode,
 	return can_set_mode(dev, mode);
 }
 
-
 /**
  * @brief Get current state
  *

Original file line number	Diff line number	Diff line change
`@@ -817,7 +817,7 @@ static inline int can_configure(const struct device *dev, enum can_mode mode,`
`817`	`817`	`uint32_t bitrate)`
`818`	`818`	`{`
`819`	`819`	`if (bitrate > 0) {`
`820`		`- int err = can_set_bitrate(dev, bitrate, 0);`
	`820`	`+ int err = can_set_bitrate(dev, bitrate, bitrate);`
`821`	`821`	`if (err != 0) {`
`822`	`822`	`return err;`
`823`	`823`	`}`
`@@ -826,7 +826,6 @@ static inline int can_configure(const struct device *dev, enum can_mode mode,`
`826`	`826`	`return can_set_mode(dev, mode);`
`827`	`827`	`}`
`828`	`828`
`829`		`-`
`830`	`829`	`/**`
`831`	`830`	`* @brief Get current state`
`832`	`831`	`*`