samples: bluetooth: hci_uart: Fix command len calculation

carlescufi · carlescufi · commit 0552d329c88c · 2021-09-07T20:47:49.000+02:00
Due to a historical error introduced during an hci_uart refactor, the
get_len() function was using the wrong HCI H4 packet identifier for
commands. Instead of using H4_CMD (0x01) it was trying to match
BT_BUF_CMD (0x00).

Signed-off-by: Carles Cufi &lt;carles.cufi@nordicsemi.no&gt;
diff --git a/samples/bluetooth/hci_uart/src/main.c b/samples/bluetooth/hci_uart/src/main.c
@@ -78,7 +78,7 @@ static bool valid_type(uint8_t type)
 static uint32_t get_len(const uint8_t *hdr_buf, uint8_t type)
 {
 	switch (type) {
-	case BT_BUF_CMD:
+	case H4_CMD:
 		return ((const struct bt_hci_cmd_hdr *)hdr_buf)->param_len;
 	case H4_ISO:
 		return sys_le16_to_cpu(((const struct bt_hci_iso_data_hdr *)hdr_buf)->slen);

Original file line number	Diff line number	Diff line change
`@@ -78,7 +78,7 @@ static bool valid_type(uint8_t type)`
`78`	`78`	`static uint32_t get_len(const uint8_t *hdr_buf, uint8_t type)`
`79`	`79`	`{`
`80`	`80`	`switch (type) {`
`81`		`- case BT_BUF_CMD:`
	`81`	`+ case H4_CMD:`
`82`	`82`	`return ((const struct bt_hci_cmd_hdr *)hdr_buf)->param_len;`
`83`	`83`	`case H4_ISO:`
`84`	`84`	`return sys_le16_to_cpu(((const struct bt_hci_iso_data_hdr *)hdr_buf)->slen);`