Bluetooth: ISO: Add NULL check in cleanup_big

Thalley · nashif · commit 06ebe239c11a · 2021-08-26T09:12:47.000-04:00
In case that creating a BIG fails due to missing
ISO channel, cleanup_big would try to access a
NULL pointer.

Signed-off-by: Emil Gydesen &lt;emil.gydesen@nordicsemi.no&gt;
diff --git a/subsys/bluetooth/host/iso.c b/subsys/bluetooth/host/iso.c
@@ -1320,7 +1320,7 @@ static void cleanup_big(struct bt_iso_big *big)
 	for (int i = 0; i < big->num_bis; i++) {
 		struct bt_iso_chan *bis = big->bis[i];
 
-		if (bis->conn) {
+		if (bis != NULL && bis->conn != NULL) {
 			bt_conn_unref(bis->conn);
 			bis->conn = NULL;
 		}

Original file line number	Diff line number	Diff line change
`@@ -1320,7 +1320,7 @@ static void cleanup_big(struct bt_iso_big *big)`
`1320`	`1320`	`for (int i = 0; i < big->num_bis; i++) {`
`1321`	`1321`	`struct bt_iso_chan *bis = big->bis[i];`
`1322`	`1322`
`1323`		`- if (bis->conn) {`
	`1323`	`+ if (bis != NULL && bis->conn != NULL) {`
`1324`	`1324`	`bt_conn_unref(bis->conn);`
`1325`	`1325`	`bis->conn = NULL;`
`1326`	`1326`	`}`