bsim_bt: run_parallel.sh: Use lowercase for internal vars

This makes it possible to tell at a glance which variables are internal
to the script and which ones are parameters to it, which is very
helpful.

This convention is pretty common. See e.g. Google's shell style guide at
https://google.github.io/styleguide/shell.xml#Naming_Conventions, and
https://github.com/icy/bash-coding-style#naming-and-styles. It's older
than those though.

Signed-off-by: Ulf Magnusson <[email protected]>

Author: ulfalizer

tests/bluetooth/bsim_bt/run_parallel.sh

@@ -6,7 +6,7 @@
 
 set -u
 
-START=$SECONDS
+start=$SECONDS
 
 function display_help(){
   echo "run_parallel.sh [-help] [options]"
@@ -31,25 +31,25 @@ i=0
 SEARCH_PATH="${SEARCH_PATH:-`pwd`}"
 
 #All the testcases we want to run:
-ALL_CASES=`find ${SEARCH_PATH} -name "*.sh" | \
+all_cases=`find ${SEARCH_PATH} -name "*.sh" | \
            grep -Ev "(/_|run_parallel|compile.sh)"`
 #we dont run ourselves
 
 RESULTS_FILE="${RESULTS_FILE:-`pwd`/../RunResults.xml}"
-TMP_RES_FILE=tmp.xml
+tmp_res_file=tmp.xml
 
-ALL_CASES_A=( $ALL_CASES )
-N_CASES=$((${#ALL_CASES_A[@]}))
+all_cases_a=( $all_cases )
+n_cases=$((${#all_cases_a[@]}))
 touch ${RESULTS_FILE}
-echo "Attempting to run ${N_CASES} cases (logging to \
+echo "Attempting to run ${n_cases} cases (logging to \
  `realpath ${RESULTS_FILE}`)"
 
-chmod +x $ALL_CASES
+chmod +x $all_cases
 
 export CLEAN_XML="sed -E -e 's/&/\&amp;/g' -e 's/</\&lt;/g' -e 's/>/\&gt;/g' \
                   -e 's/\"/&quot;/g'"
 
-echo -n "" > $TMP_RES_FILE
+echo -n "" > $tmp_res_file
 
 if [ `command -v parallel` ]; then
   parallel '
@@ -69,31 +69,31 @@ if [ `command -v parallel` ]; then
     rm {#}.log ;
     echo "</testcase>";
   fi;
-  ' ::: $ALL_CASES >> $TMP_RES_FILE ; err=$?
+  ' ::: $all_cases >> $tmp_res_file ; err=$?
 else #fallback in case parallel is not installed
-  for CASE in $ALL_CASES; do
-    echo "<testcase name=\"$CASE\" time=\"0\">" >> $TMP_RES_FILE
-    $CASE $@ &> $i.log
+  for case in $all_cases; do
+    echo "<testcase name=\"$case\" time=\"0\">" >> $tmp_res_file
+    $case $@ &> $i.log
     if [ $? -ne 0 ]; then
-      echo -e "\e[91m$CASE FAILED\e[39m"
+      echo -e "\e[91m$case FAILED\e[39m"
       cat $i.log
-      echo "<failure message=\"failed\" type=\"failure\">" >> $TMP_RES_FILE
-      cat $i.log | eval $CLEAN_XML >> $TMP_RES_FILE
-      echo "</failure>" >> $TMP_RES_FILE
+      echo "<failure message=\"failed\" type=\"failure\">" >> $tmp_res_file
+      cat $i.log | eval $CLEAN_XML >> $tmp_res_file
+      echo "</failure>" >> $tmp_res_file
       let "err++"
     else
-      echo -e "$CASE PASSED"
+      echo -e "$case PASSED"
     fi;
-    echo "</testcase>" >> $TMP_RES_FILE
+    echo "</testcase>" >> $tmp_res_file
     rm $i.log
     let i=i+1
   done
 fi
-echo -e "</testsuite>\n</testsuites>\n" >> $TMP_RES_FILE
-dur=$(($SECONDS - $START))
+echo -e "</testsuite>\n</testsuites>\n" >> $tmp_res_file
+dur=$(($SECONDS - $start))
 echo -e "<testsuites>\n<testsuite errors=\"0\" failures=\"$err\"\
- name=\"bsim_bt tests\" skip=\"0\" tests=\"$N_CASES\" time=\"$dur\">" \
- | cat - $TMP_RES_FILE > $RESULTS_FILE
-rm $TMP_RES_FILE
+ name=\"bsim_bt tests\" skip=\"0\" tests=\"$n_cases\" time=\"$dur\">" \
+ | cat - $tmp_res_file > $RESULTS_FILE
+rm $tmp_res_file
 
 exit $err