drivers: dma: si32: Improve start and stop logic

As per dma_stop() documentation, the implementation has to not just stop
the transfer, but also to disable the channel. Before this commit, only
the transfer has been stopped.

Same goes for dma_start(). This also allows the enabling of a channel to
be removed from dma_si32_config().

Signed-off-by: Reto Schneider <[email protected]>

Author: rettichschnidi

drivers/dma/dma_si32.c

@@ -333,8 +333,6 @@ static int dma_si32_config(const struct device *dev, uint32_t channel, struct dm
 		return -EINVAL;
 	}
 
-	SI32_DMACTRL_A_enable_channel(SI32_DMACTRL_0, channel);
-
 	return 0;
 }
 
@@ -365,7 +363,6 @@ static int dma_si32_start(const struct device *dev, const uint32_t channel)
 	__ASSERT(SI32_DMACTRL_A_is_primary_selected(SI32_DMACTRL_0, channel),
 		 "Primary descriptors must be used for basic and auto-request operations.");
 	__ASSERT(SI32_SCONFIG_0->CONFIG.FDMAEN, "Fast mode is recommened to be enabled.");
-	__ASSERT(SI32_DMACTRL_0->CHENSET.U32 & BIT(channel), "Channel must be enabled.");
 	__ASSERT(SI32_DMACTRL_0->CHSTATUS.U32 & BIT(channel),
 		 "Channel must be waiting for request");
 
@@ -377,6 +374,8 @@ static int dma_si32_start(const struct device *dev, const uint32_t channel)
 	/* Enable interrupt for this DMA channels. */
 	irq_enable(DMACH0_IRQn + channel);
 
+	SI32_DMACTRL_A_enable_channel(SI32_DMACTRL_0, channel);
+
 	/* memory-to-memory transfers have to be started by this driver. When peripherals are
 	 * involved, the caller has to enable the peripheral to start the transfer.
 	 */
@@ -405,6 +404,8 @@ static int dma_si32_stop(const struct device *dev, const uint32_t channel)
 
 	channel_descriptors[channel].CONFIG.TMD = 0; /* Stop the DMA channel. */
 
+	SI32_DMACTRL_A_disable_channel(SI32_DMACTRL_0, channel);
+
 	return 0;
 }