net: connection: Use NET_CONN_*_PORT_SPEC flag when comparing ports

The NET_CONN_LOCAL/REMOTE_PORT_SPEC flags were set on the connection but
not really used. At the same time, when remote address was being
cleared, only the flag was unset, but the actual port number left
intact. This could lead to false port comparisons when remote address
was cleared from the connection context.

In order to avoid that, use the NET_CONN_*_PORT_SPEC flags to determine
whether to compare local/remote ports instead of checking the port value
right away (which may not be valid anymore if the flag is unset).

Also align with MISRA rules when comparing flags in other cases.

Signed-off-by: Robert Lubos <[email protected]>

Author: rlubos

subsys/net/ip/connection.c

@@ -970,22 +970,22 @@ enum net_verdict net_conn_input(struct net_pkt *pkt,
 			/* Is the candidate connection matching the packet's TCP/UDP
 			 * address and port?
 			 */
-			if (net_sin(&conn->remote_addr)->sin_port &&
+			if ((conn->flags & NET_CONN_REMOTE_PORT_SPEC) != 0 &&
 			    net_sin(&conn->remote_addr)->sin_port != src_port) {
 				continue; /* wrong remote port */
 			}
 
-			if (net_sin(&conn->local_addr)->sin_port &&
+			if ((conn->flags & NET_CONN_LOCAL_PORT_SPEC) != 0 &&
 			    net_sin(&conn->local_addr)->sin_port != dst_port) {
 				continue; /* wrong local port */
 			}
 
-			if ((conn->flags & NET_CONN_REMOTE_ADDR_SET) &&
+			if ((conn->flags & NET_CONN_REMOTE_ADDR_SET) != 0 &&
 			    !conn_addr_cmp(pkt, ip_hdr, &conn->remote_addr, true)) {
 				continue; /* wrong remote address */
 			}
 
-			if ((conn->flags & NET_CONN_LOCAL_ADDR_SET) &&
+			if ((conn->flags & NET_CONN_LOCAL_ADDR_SET) != 0 &&
 			    !conn_addr_cmp(pkt, ip_hdr, &conn->local_addr, false)) {
 
 				/* Check if we could do a v4-mapping-to-v6 and the IPv6 socket