drivers: mspi_dw: Remove needless TXEIR check

This is a follow-up to commit f0f5f8c.

There is no need to check if TXE interrupt flag is set before
calling tx_dummy_bytes(), as the function can handle the case
when it is called even though there is no room in the TX FIFO.
On the other hand, the check may be actually harmful, as it may
prevent adding more items to the TX FIFO while the SSI controller
is waiting until the FIFO achieves its transfer start level.
Remove the check then and exit the ISR loop when no dummy bytes
could be written into the TX FIFO.

Signed-off-by: Andrzej Głąbek <[email protected]>

Author: anangl

drivers/mspi/mspi_dw.c

@@ -195,7 +195,7 @@ static void tx_data(const struct device *dev,
 	dev_data->buf_pos = (uint8_t *)buf_pos;
 }
 
-static bool tx_dummy_bytes(const struct device *dev)
+static bool tx_dummy_bytes(const struct device *dev, bool *repeat)
 {
 	struct mspi_dw_data *dev_data = dev->data;
 	const struct mspi_dw_config *dev_config = dev->config;
@@ -209,8 +209,17 @@ static bool tx_dummy_bytes(const struct device *dev)
 	 * FIFO to avoid overflowing it; `max_queued_dummy_bytes` accounts
 	 * that one byte that can be partially received, thus not included
 	 * in the value from the RXFLR register.
+	 * This check also handles the case when the function is called but
+	 * the TX FIFO is already filled up (fifo_room == 0).
 	 */
 	if (fifo_room <= rx_fifo_items) {
+		if (repeat) {
+			/* If no dummy bytes can be sent now, there is no point
+			 * in repeating the loop that reads the RX FIFO.
+			 */
+			*repeat = false;
+		}
+
 		return false;
 	}
 	fifo_room -= rx_fifo_items;
@@ -329,7 +338,9 @@ static void handle_fifos(const struct device *dev)
 			finished = true;
 		}
 	} else {
-		for (;;) {
+		bool repeat = true;
+
+		do {
 			/* Always read everything from the RX FIFO, regardless
 			 * of the interrupt status.
 			 * tx_dummy_bytes() subtracts the number of items that
@@ -363,19 +374,28 @@ static void handle_fifos(const struct device *dev)
 				break;
 			}
 
-			if (dev_data->dummy_bytes == 0 ||
-			    !(int_status & RISR_TXEIR_BIT)) {
+			/* If there are still some dummy bytes to transmit,
+			 * always try to put some into the TX FIFO, no matter
+			 * what's the TXE interrupt status - the TX FIFO may be
+			 * filled above its threshold level (then its interrupt
+			 * flag is not set), but below its transfer start level,
+			 * so the controller may be waiting for more items to
+			 * appear there.
+			 */
+			if (dev_data->dummy_bytes == 0) {
 				break;
 			}
 
-			if (tx_dummy_bytes(dev)) {
+			if (tx_dummy_bytes(dev, &repeat)) {
 				/* All the required dummy bytes were written
 				 * to the FIFO; disable the TXE interrupt,
 				 * as it's no longer needed.
 				 */
 				set_imr(dev, IMR_RXFIM_BIT);
 			}
-		}
+
+			/* Repeat the loop only if any dummy bytes were sent. */
+		} while (repeat);
 	}
 
 	if (finished) {
@@ -404,6 +424,8 @@ static void fifo_work_handler(struct k_work *work)
 
 static void mspi_dw_isr(const struct device *dev)
 {
+	NRF_P9->OUTSET = BIT(1);
+
 #if defined(CONFIG_MSPI_DW_HANDLE_FIFOS_IN_SYSTEM_WORKQUEUE)
 	struct mspi_dw_data *dev_data = dev->data;
 	int rc;
@@ -420,6 +442,8 @@ static void mspi_dw_isr(const struct device *dev)
 #endif
 
 	vendor_specific_irq_clear(dev);
+
+	NRF_P9->OUTCLR = BIT(1);
 }
 
 static int api_config(const struct mspi_dt_spec *spec)
@@ -1151,7 +1175,7 @@ static int start_next_packet(const struct device *dev, k_timeout_t timeout)
 	}
 
 	/* Prefill TX FIFO with any data we can */
-	if (dev_data->dummy_bytes && tx_dummy_bytes(dev)) {
+	if (dev_data->dummy_bytes && tx_dummy_bytes(dev, NULL)) {
 		imr = IMR_RXFIM_BIT;
 	} else if (packet->dir == MSPI_TX && packet->num_bytes) {
 		tx_data(dev, packet);