Bluetooth: Host: Fix silent LE conn param update command failure

joerchan · jhedberg · commit 113b80ff0dbf · 2019-11-21T17:21:01.000+02:00
Fix command status for LE Command Param Update HCI command silently
dropped by the host without notifying the application that this command
has failed. This happens because the host does not wait for the command
status event to check the status code returned.

Signed-off-by: Joakim Andersson &lt;joakim.andersson@nordicsemi.no&gt;
diff --git a/subsys/bluetooth/host/conn.c b/subsys/bluetooth/host/conn.c
@@ -2279,7 +2279,7 @@ int bt_conn_le_conn_update(struct bt_conn *conn,
 	conn_update->conn_latency = sys_cpu_to_le16(param->latency);
 	conn_update->supervision_timeout = sys_cpu_to_le16(param->timeout);
 
-	return bt_hci_cmd_send(BT_HCI_OP_LE_CONN_UPDATE, buf);
+	return bt_hci_cmd_send_sync(BT_HCI_OP_LE_CONN_UPDATE, buf, NULL);
 }
 
 struct net_buf *bt_conn_create_pdu_timeout(struct net_buf_pool *pool,

Original file line number	Diff line number	Diff line change
`@@ -2279,7 +2279,7 @@ int bt_conn_le_conn_update(struct bt_conn *conn,`
`2279`	`2279`	`conn_update->conn_latency = sys_cpu_to_le16(param->latency);`
`2280`	`2280`	`conn_update->supervision_timeout = sys_cpu_to_le16(param->timeout);`
`2281`	`2281`
`2282`		`- return bt_hci_cmd_send(BT_HCI_OP_LE_CONN_UPDATE, buf);`
	`2282`	`+ return bt_hci_cmd_send_sync(BT_HCI_OP_LE_CONN_UPDATE, buf, NULL);`
`2283`	`2283`	`}`
`2284`	`2284`
`2285`	`2285`	`struct net_buf bt_conn_create_pdu_timeout(struct net_buf_pool pool,`