kernel: sched: inline update_cache

nashif · nashif · commit 121cb49a46eb · 2024-10-10T20:21:04.000-04:00
This improves context switching by 7% when measured using the
thread_metric benchmark.

Before:
**** Thread-Metric Preemptive Scheduling Test **** Relative Time: 120
Time Period Total:  5451879

After:
**** Thread-Metric Preemptive Scheduling Test **** Relative Time: 30
Time Period Total:  5853535

Signed-off-by: Anas Nashif &lt;anas.nashif@intel.com&gt;
diff --git a/kernel/sched.c b/kernel/sched.c
@@ -35,7 +35,7 @@ struct k_spinlock _sched_spinlock;
  */
 __incoherent struct k_thread _thread_dummy;
 
-static void update_cache(int preempt_ok);
+static ALWAYS_INLINE void update_cache(int preempt_ok);
 static void halt_thread(struct k_thread *thread, uint8_t new_state);
 static void add_to_waitq_locked(struct k_thread *thread, _wait_q_t *wait_q);
 
@@ -320,7 +320,7 @@ static void update_metairq_preempt(struct k_thread *thread)
  */
 }
 
-static void update_cache(int preempt_ok)
+static ALWAYS_INLINE void update_cache(int preempt_ok)
 {
 #ifndef CONFIG_SMP
 	struct k_thread *thread = next_up();

Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ struct k_spinlock _sched_spinlock;`
`35`	`35`	`*/`
`36`	`36`	`__incoherent struct k_thread _thread_dummy;`
`37`	`37`
`38`		`-static void update_cache(int preempt_ok);`
	`38`	`+static ALWAYS_INLINE void update_cache(int preempt_ok);`
`39`	`39`	`static void halt_thread(struct k_thread *thread, uint8_t new_state);`
`40`	`40`	`static void add_to_waitq_locked(struct k_thread thread, _wait_q_t wait_q);`
`41`	`41`
`@@ -320,7 +320,7 @@ static void update_metairq_preempt(struct k_thread *thread)`
`320`	`320`	`*/`
`321`	`321`	`}`
`322`	`322`
`323`		`-static void update_cache(int preempt_ok)`
	`323`	`+static ALWAYS_INLINE void update_cache(int preempt_ok)`
`324`	`324`	`{`
`325`	`325`	`#ifndef CONFIG_SMP`
`326`	`326`	`struct k_thread *thread = next_up();`