scripts: Remove unused variables in all Python scripts

Discovered with pylint3.

Use the placeholder name '_' for unproblematic unused variables. It's
what I'm used to, and pylint knows not to flag it.

Python tip:

    for i in range(n):
        some_list.append(0)

can be replaced with

    some_list += n*[0]

Similarly, 3*'\t' gives '\t\t\t'.

(Relevant here because pylint flagged the loop index as unused.)

To do integer division in Python 3, use // instead of /.

Signed-off-by: Ulf Magnusson <[email protected]>

Author: ulfalizer

arch/common/gen_isr_tables.py

@@ -223,7 +223,6 @@ def main():
     intlist = read_intlist(args.intlist)
     nvec = intlist["num_vectors"]
     offset = intlist["offset"]
-    prefix = endian_prefix()
 
     spurious_handler = "&z_irq_spurious"
     sw_irq_handler   = "ISR_WRAPPER"

arch/x86/gen_mmu_x86.py

@@ -394,7 +394,7 @@ def page_directory_create_binary_file(self):
                 self.output_offset += struct.calcsize(page_entry_format)
 
     def page_table_create_binary_file(self):
-        for pdpte, pde_info in sorted(self.list_of_pdpte.items()):
+        for _, pde_info in sorted(self.list_of_pdpte.items()):
             for pde, pte_info in sorted(pde_info.pd_entries.items()):
                 pe_info = pte_info.page_entries_info[0]
                 start_addr = pe_info.start_addr & ~0x1FFFFF

arch/xtensa/core/xtensa_intgen.py

@@ -29,8 +29,7 @@ def cprint(s):
         return
     if s.find("}") >= 0:
         cindent -= 1
-    for xx in range(cindent):
-        s = "\t" + s
+    s = cindent*"\t" + s
     print(s)
     if s.find("{") >= 0:
         cindent += 1

boards/xtensa/intel_s1000_crb/support/create_board_img.py

@@ -188,9 +188,8 @@ def main():
     ipc_load_fw(SRAM_SIZE, FLASH_PART_TABLE_OFFSET)
 
     # pad zeros until FLASH_PART_TABLE_OFFSET
-    num_zero_pad = (FLASH_PART_TABLE_OFFSET / 4) - len(flash_content)
-    for x in range(int(num_zero_pad)):
-        flash_content.append(0)
+    num_zero_pad = FLASH_PART_TABLE_OFFSET // 4 - len(flash_content)
+    flash_content += num_zero_pad * [0]
 
     # read contents of firmware input file and change the endianness
     with open(args.in_file, "rb") as in_fp:
@@ -203,8 +202,7 @@ def main():
             write_buf.append(read_buf[itr*4 + 0])
 
         # pad zeros until the sector boundary
-        for x in range(zeropad_size):
-            write_buf.append(0)
+        write_buf += zeropad_size*[0]
 
     # Generate the file which should be downloaded to Flash
     with open(args.out_file, "wb") as out_fp:

doc/extensions/local_util.py

@@ -57,7 +57,7 @@ def copy_if_modified(src_path, dst_path):
         return
 
     src_path_len = len(src_path)
-    for root, dirs, files in os.walk(src_path):
+    for root, _, files in os.walk(src_path):
         for src_file_name in files:
             src_file_path = os.path.join(root, src_file_name)
             dst_file_path = os.path.join(dst_path + root[src_path_len:], src_file_name)

doc/extensions/zephyr/application.py

@@ -164,7 +164,6 @@ def run(self):
                                                 if v != 'all']
         # Build the command content as a list, then convert to string.
         content = []
-        lit = []
         cd_to = zephyr_app or app
         tool_comment = None
         if len(tools) > 1:
@@ -336,7 +335,6 @@ def _generate_cmake(self, **kwargs):
         zephyr_app = kwargs['zephyr_app']
         host_os = kwargs['host_os']
         build_dir = kwargs['build_dir']
-        source_dir = kwargs['source_dir']
         skip_config = kwargs['skip_config']
         compact = kwargs['compact']
         generator = kwargs['generator']

ext/hal/nxp/mcux/scripts/import_mcux_sdk.py

@@ -65,15 +65,15 @@ def import_sdk(directory):
 
         device_src = os.path.join(directory, 'devices', device)
         device_pattern = "|".join([device, 'fsl_device_registers'])
-        [device_headers, ignore] = get_files(device_src, device_pattern)
+        device_headers, _ = get_files(device_src, device_pattern)
 
         drivers_src = os.path.join(directory, 'devices', device, 'drivers')
         drivers_pattern = "fsl_clock|fsl_iomuxc"
         [device_drivers, shared_drivers] = get_files(drivers_src, drivers_pattern)
 
         xip_boot_src = os.path.join(directory, 'devices', device, 'xip')
         xip_boot_pattern = ".*"
-        [xip_boot, ignore] = get_files(xip_boot_src, xip_boot_pattern)
+        xip_boot, _ = get_files(xip_boot_src, xip_boot_pattern)
 
         print('Importing {} device headers to {}'.format(device, device_dst))
         copy_files(device_headers, device_dst)
@@ -93,7 +93,7 @@ def import_sdk(directory):
 
         xip_config_src = os.path.join(board_src, 'xip')
         xip_config_pattern = ".*"
-        [xip_config, ignore] = get_files(xip_config_src, xip_config_pattern)
+        xip_config, _ = get_files(xip_config_src, xip_config_pattern)
 
         print('Importing {} xip config to {}'.format(board, board_dst))
         copy_files(xip_config, board_dst)

scripts/elf_helper.py

@@ -386,7 +386,7 @@ def find_kobjects(self, syms):
 
         # Step 1: collect all type information.
         for CU in di.iter_CUs():
-            for idx, die in enumerate(CU.iter_DIEs()):
+            for die in CU.iter_DIEs():
                 # Unions are disregarded, kernel objects should never be union
                 # members since the memory is not dedicated to that object and
                 # could be something else

scripts/filter-known-issues.py

@@ -89,7 +89,7 @@ def config_import_path(path):
     """
     file_regex = re.compile(".*\.conf$")
     try:
-        for dirpath, dirnames, filenames in os.walk(path):
+        for dirpath, _, filenames in os.walk(path):
             for _filename in sorted(filenames):
                 filename = os.path.join(dirpath, _filename)
                 if not file_regex.search(_filename):

scripts/gen_app_partitions.py

@@ -128,7 +128,7 @@ def find_obj_file_partitions(filename, partitions):
 
 def parse_obj_files(partitions):
     # Iterate over all object files to find partitions
-    for dirpath, dirs, files in os.walk(args.directory):
+    for dirpath, _, files in os.walk(args.directory):
         for filename in files:
             if re.match(".*\.obj$",filename):
                 fullname = os.path.join(dirpath, filename)
@@ -143,7 +143,7 @@ def parse_elf_file(partitions):
                        if isinstance(s, SymbolTableSection)]
 
         for section in symbol_tbls:
-            for nsym, symbol in enumerate(section.iter_symbols()):
+            for symbol in section.iter_symbols():
                 if symbol['st_shndx'] != "SHN_ABS":
                     continue
 
@@ -206,7 +206,6 @@ def parse_args():
 
 def main():
     parse_args()
-    linker_file = args.output
     partitions = {}
 
     if args.directory is not None: