Skip to content

Commit 13cad59

Browse files
fgervaismmahadevan108
authored andcommitted
tests: coap_client: wait enough for requests to be unallocated
As confirmable requests will stay allocated for (3 * ACK_TIMEOUT), we need to adjust the timings so all requests are unallocated by the end of the test. Signed-off-by: Francois Gervais <[email protected]>
1 parent bfed8d0 commit 13cad59

File tree

2 files changed

+5
-15
lines changed

2 files changed

+5
-15
lines changed

tests/net/lib/coap_client/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ add_compile_definitions(CONFIG_COAP_CLIENT_MESSAGE_HEADER_SIZE=48)
2626
add_compile_definitions(CONFIG_COAP_CLIENT_STACK_SIZE=1024)
2727
add_compile_definitions(CONFIG_COAP_CLIENT_THREAD_PRIORITY=10)
2828
add_compile_definitions(CONFIG_COAP_LOG_LEVEL=4)
29-
add_compile_definitions(CONFIG_COAP_INIT_ACK_TIMEOUT_MS=200)
29+
add_compile_definitions(CONFIG_COAP_INIT_ACK_TIMEOUT_MS=10)
3030
add_compile_definitions(CONFIG_COAP_CLIENT_MAX_REQUESTS=2)
3131
add_compile_definitions(CONFIG_COAP_CLIENT_MAX_INSTANCES=2)
3232
add_compile_definitions(CONFIG_COAP_MAX_RETRANSMIT=4)

tests/net/lib/coap_client/src/main.c

Lines changed: 4 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -377,7 +377,6 @@ ZTEST(coap_client, test_get_request)
377377
zassert_true(ret >= 0, "Sending request failed, %d", ret);
378378
set_socket_events(ZSOCK_POLLIN);
379379

380-
k_sleep(K_MSEC(5));
381380
k_sleep(K_MSEC(100));
382381
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
383382
}
@@ -406,7 +405,7 @@ ZTEST(coap_client, test_resend_request)
406405
LOG_INF("Send request");
407406
ret = coap_client_req(&client, 0, &address, &client_request, NULL);
408407
zassert_true(ret >= 0, "Sending request failed, %d", ret);
409-
k_sleep(K_MSEC(300));
408+
k_sleep(K_MSEC(15));
410409
set_socket_events(ZSOCK_POLLIN);
411410

412411
k_sleep(K_MSEC(100));
@@ -440,7 +439,6 @@ ZTEST(coap_client, test_echo_option)
440439
zassert_true(ret >= 0, "Sending request failed, %d", ret);
441440
set_socket_events(ZSOCK_POLLIN);
442441

443-
k_sleep(K_MSEC(5));
444442
k_sleep(K_MSEC(100));
445443
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
446444
}
@@ -471,7 +469,6 @@ ZTEST(coap_client, test_echo_option_next_req)
471469
zassert_true(ret >= 0, "Sending request failed, %d", ret);
472470
set_socket_events(ZSOCK_POLLIN);
473471

474-
k_sleep(K_MSEC(5));
475472
k_sleep(K_MSEC(100));
476473
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
477474

@@ -486,7 +483,6 @@ ZTEST(coap_client, test_echo_option_next_req)
486483
zassert_true(ret >= 0, "Sending request failed, %d", ret);
487484
set_socket_events(ZSOCK_POLLIN);
488485

489-
k_sleep(K_MSEC(5));
490486
k_sleep(K_MSEC(100));
491487
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
492488
}
@@ -540,7 +536,6 @@ ZTEST(coap_client, test_send_large_data)
540536
zassert_true(ret >= 0, "Sending request failed, %d", ret);
541537
set_socket_events(ZSOCK_POLLIN);
542538

543-
k_sleep(K_MSEC(5));
544539
k_sleep(K_MSEC(100));
545540
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
546541
}
@@ -574,8 +569,8 @@ ZTEST(coap_client, test_no_response)
574569
ret = coap_client_req(&client, 0, &address, &client_request, &params);
575570

576571
zassert_true(ret >= 0, "Sending request failed, %d", ret);
577-
k_sleep(K_MSEC(300));
578572

573+
k_sleep(K_MSEC(700));
579574
zassert_equal(last_response_code, -ETIMEDOUT, "Unexpected response");
580575
}
581576

@@ -605,9 +600,7 @@ ZTEST(coap_client, test_separate_response)
605600
zassert_true(ret >= 0, "Sending request failed, %d", ret);
606601
set_socket_events(ZSOCK_POLLIN);
607602

608-
k_sleep(K_MSEC(5));
609603
k_sleep(K_MSEC(100));
610-
611604
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
612605
}
613606

@@ -638,11 +631,9 @@ ZTEST(coap_client, test_multiple_requests)
638631
ret = coap_client_req(&client, 0, &address, &client_request, NULL);
639632
zassert_true(ret >= 0, "Sending request failed, %d", ret);
640633

641-
k_sleep(K_MSEC(5));
642634
k_sleep(K_MSEC(100));
643635
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
644636

645-
k_sleep(K_MSEC(5));
646637
k_sleep(K_MSEC(100));
647638
zassert_equal(last_response_code, COAP_RESPONSE_CODE_OK, "Unexpected response");
648639
}
@@ -676,9 +667,8 @@ ZTEST(coap_client, test_unmatching_tokens)
676667
zassert_true(ret >= 0, "Sending request failed, %d", ret);
677668
set_socket_events(ZSOCK_POLLIN);
678669

679-
k_sleep(K_MSEC(1));
680-
k_sleep(K_MSEC(1));
670+
k_sleep(K_MSEC(2));
681671
clear_socket_events();
682-
k_sleep(K_MSEC(500));
672+
k_sleep(K_MSEC(700));
683673
zassert_equal(last_response_code, -ETIMEDOUT, "Unexpected response");
684674
}

0 commit comments

Comments
 (0)