net: lwm2m: Fix unitialized variable error in Link Format writer

rlubos · MaureenHelm · commit 19e7451c3424 · 2021-04-14T14:36:35.000-05:00
The `init_string` array could have been used uninitialized, fix this by initializing it as an empty string, which is a desired content in case it's not overwritten. CID: 220302 Fixes #33839 Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
diff --git a/subsys/net/lib/lwm2m/lwm2m_rw_link_format.c b/subsys/net/lib/lwm2m/lwm2m_rw_link_format.c
@@ -51,7 +51,7 @@ struct link_format_out_formatter_data {
 static size_t put_begin(struct lwm2m_output_context *out,
 			struct lwm2m_obj_path *path)
 {
-	char init_string[MAX(sizeof(ENABLER_VERSION), sizeof(REG_PREFACE))];
+	char init_string[MAX(sizeof(ENABLER_VERSION), sizeof(REG_PREFACE))] = "";
 	struct link_format_out_formatter_data *fd;
 	int ret;
 

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ struct link_format_out_formatter_data {`
`51`	`51`	`static size_t put_begin(struct lwm2m_output_context *out,`
`52`	`52`	`struct lwm2m_obj_path *path)`
`53`	`53`	`{`
`54`		`- char init_string[MAX(sizeof(ENABLER_VERSION), sizeof(REG_PREFACE))];`
	`54`	`+ char init_string[MAX(sizeof(ENABLER_VERSION), sizeof(REG_PREFACE))] = "";`
`55`	`55`	`struct link_format_out_formatter_data *fd;`
`56`	`56`	`int ret;`
`57`	`57`