Skip to content

Commit 1ce3898

Browse files
aescolarkartben
authored andcommitted
tests pipe_api: Fix unitialized variable warning
Fix so the compiler does not throw a warning thinking that those buffers may be used unitialized inside k_pipe_write/read(). Note clang does not the array size being of a variable size and initialized as it throws a "error: variable length array folded to constant array as an extension" The issue was discovered with with gcc 14.2 Signed-off-by: Alberto Escolar Piedras <[email protected]>
1 parent 4b55a13 commit 1ce3898

File tree

1 file changed

+13
-13
lines changed

1 file changed

+13
-13
lines changed

tests/kernel/pipe/pipe_api/src/concurrency.c

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ LOG_MODULE_REGISTER(k_pipe_concurrency, LOG_LEVEL_DBG);
1313
ZTEST_SUITE(k_pipe_concurrency, NULL, NULL, NULL, NULL, NULL);
1414

1515
static const int partial_wait_time = 2000;
16-
static const int dummy_data_size = 16;
16+
#define DUMMY_DATA_SIZE 16
1717
static struct k_thread thread;
1818
static K_THREAD_STACK_DEFINE(stack, 1024);
1919

@@ -29,15 +29,15 @@ static void thread_reset(void *arg1, void *arg2, void *arg3)
2929

3030
static void thread_write(void *arg1, void *arg2, void *arg3)
3131
{
32-
uint8_t garbage[dummy_data_size];
32+
uint8_t garbage[DUMMY_DATA_SIZE] = {};
3333

3434
zassert_true(k_pipe_write((struct k_pipe *)arg1, garbage, sizeof(garbage),
3535
K_MSEC(partial_wait_time)) == sizeof(garbage), "Failed to write to pipe");
3636
}
3737

3838
static void thread_read(void *arg1, void *arg2, void *arg3)
3939
{
40-
uint8_t garbage[dummy_data_size];
40+
uint8_t garbage[DUMMY_DATA_SIZE];
4141

4242
zassert_true(k_pipe_read((struct k_pipe *)arg1, garbage, sizeof(garbage),
4343
K_MSEC(partial_wait_time)) == sizeof(garbage), "Failed to read from pipe");
@@ -47,7 +47,7 @@ ZTEST(k_pipe_concurrency, test_close_on_read)
4747
{
4848
k_tid_t tid;
4949
struct k_pipe pipe;
50-
uint8_t buffer[dummy_data_size];
50+
uint8_t buffer[DUMMY_DATA_SIZE];
5151
uint8_t res;
5252

5353
k_pipe_init(&pipe, buffer, sizeof(buffer));
@@ -65,8 +65,8 @@ ZTEST(k_pipe_concurrency, test_close_on_write)
6565
{
6666
k_tid_t tid;
6767
struct k_pipe pipe;
68-
uint8_t buffer[dummy_data_size];
69-
uint8_t garbage[dummy_data_size];
68+
uint8_t buffer[DUMMY_DATA_SIZE];
69+
uint8_t garbage[DUMMY_DATA_SIZE];
7070

7171
k_pipe_init(&pipe, buffer, sizeof(buffer));
7272
zassert_true(sizeof(garbage) == k_pipe_write(&pipe, garbage, sizeof(garbage), K_MSEC(1000)),
@@ -86,7 +86,7 @@ ZTEST(k_pipe_concurrency, test_reset_on_read)
8686
{
8787
k_tid_t tid;
8888
struct k_pipe pipe;
89-
uint8_t buffer[dummy_data_size];
89+
uint8_t buffer[DUMMY_DATA_SIZE];
9090
uint8_t res;
9191

9292
k_pipe_init(&pipe, buffer, sizeof(buffer));
@@ -107,8 +107,8 @@ ZTEST(k_pipe_concurrency, test_reset_on_write)
107107
{
108108
k_tid_t tid;
109109
struct k_pipe pipe;
110-
uint8_t buffer[dummy_data_size];
111-
uint8_t garbage[dummy_data_size];
110+
uint8_t buffer[DUMMY_DATA_SIZE];
111+
uint8_t garbage[DUMMY_DATA_SIZE];
112112

113113
k_pipe_init(&pipe, buffer, sizeof(buffer));
114114
zassert_true(sizeof(garbage) == k_pipe_write(&pipe, garbage, sizeof(garbage), K_MSEC(1000)),
@@ -130,8 +130,8 @@ ZTEST(k_pipe_concurrency, test_partial_read)
130130
{
131131
k_tid_t tid;
132132
struct k_pipe pipe;
133-
uint8_t buffer[dummy_data_size];
134-
uint8_t garbage[dummy_data_size];
133+
uint8_t buffer[DUMMY_DATA_SIZE];
134+
uint8_t garbage[DUMMY_DATA_SIZE];
135135
size_t write_size = sizeof(garbage)/2;
136136

137137
k_pipe_init(&pipe, buffer, sizeof(buffer));
@@ -150,8 +150,8 @@ ZTEST(k_pipe_concurrency, test_partial_write)
150150
{
151151
k_tid_t tid;
152152
struct k_pipe pipe;
153-
uint8_t buffer[dummy_data_size];
154-
uint8_t garbage[dummy_data_size];
153+
uint8_t buffer[DUMMY_DATA_SIZE];
154+
uint8_t garbage[DUMMY_DATA_SIZE];
155155
size_t read_size = sizeof(garbage)/2;
156156

157157
k_pipe_init(&pipe, buffer, sizeof(buffer));

0 commit comments

Comments
 (0)