Skip to content

Commit 1de84d2

Browse files
jfischer-nocfriedt
authored andcommitted
usb: cdc_acm: configure CDC ACM UART instances using devicetree only
Remove the possibility to configure number of CDC ACM UART instances in Kconfig. Signed-off-by: Johann Fischer <[email protected]>
1 parent 03669db commit 1de84d2

File tree

2 files changed

+1
-38
lines changed

2 files changed

+1
-38
lines changed

subsys/usb/class/Kconfig.cdc

Lines changed: 1 addition & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -5,23 +5,16 @@ DT_COMPAT_ZEPHYR_CDC_ACM_UART := zephyr,cdc-acm-uart
55

66
menu "USB CDC ACM Class support"
77

8-
config USB_CDC_ACM_HAS_DT_COMPAT
9-
bool
10-
default $(dt_compat_enabled,$(DT_COMPAT_ZEPHYR_CDC_ACM_UART))
11-
imply USB_CDC_ACM
12-
help
13-
Helper symbol to select USB_CDC_ACM if compatible node is enabled.
14-
158
config USB_CDC_ACM
169
bool "USB CDC ACM Class support"
1710
depends on SERIAL
11+
default $(dt_compat_enabled,$(DT_COMPAT_ZEPHYR_CDC_ACM_UART))
1812
select SERIAL_HAS_DRIVER
1913
select SERIAL_SUPPORT_INTERRUPT
2014
select RING_BUFFER
2115
select UART_INTERRUPT_DRIVEN
2216
help
2317
USB CDC ACM class support.
24-
Default UART device name is "CDC_ACM_0".
2518

2619
if USB_CDC_ACM
2720

@@ -31,19 +24,6 @@ config USB_CDC_ACM_RINGBUF_SIZE
3124
help
3225
USB CDC ACM ring buffer size
3326

34-
config USB_CDC_ACM_DEVICE_NAME
35-
string "USB CDC ACM device name template"
36-
default "CDC_ACM"
37-
help
38-
Device name template for the CDC ACM Devices. First device would
39-
have name $(USB_CDC_ACM_DEVICE_NAME)_0, etc.
40-
41-
if !USB_CDC_ACM_HAS_DT_COMPAT
42-
module = USB_CDC_ACM
43-
default-count = 1
44-
source "subsys/usb/class/Kconfig.template.composite_device_number"
45-
endif
46-
4727
config CDC_ACM_INTERRUPT_EP_MPS
4828
int
4929
default 16

subsys/usb/class/cdc_acm.c

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1088,19 +1088,6 @@ static const struct uart_driver_api cdc_acm_driver_api = {
10881088
.tx_ringbuf = &tx_ringbuf_##x, \
10891089
};
10901090

1091-
#define CDC_ACM_DEVICE_DEFINE(idx, _) \
1092-
CDC_ACM_CFG_AND_DATA_DEFINE(idx) \
1093-
\
1094-
DEVICE_DEFINE(cdc_acm_##idx, \
1095-
CONFIG_USB_CDC_ACM_DEVICE_NAME "_" #idx, \
1096-
cdc_acm_init, NULL, \
1097-
&cdc_acm_dev_data_##idx, \
1098-
&cdc_acm_config_##idx, \
1099-
POST_KERNEL, \
1100-
CONFIG_KERNEL_INIT_PRIORITY_DEVICE, \
1101-
&cdc_acm_driver_api);
1102-
1103-
11041091
#define DT_DRV_COMPAT zephyr_cdc_acm_uart
11051092

11061093
#define CDC_ACM_DT_DEVICE_DEFINE(idx) \
@@ -1114,8 +1101,4 @@ static const struct uart_driver_api cdc_acm_driver_api = {
11141101
POST_KERNEL, CONFIG_KERNEL_INIT_PRIORITY_DEVICE, \
11151102
&cdc_acm_driver_api);
11161103

1117-
#if DT_HAS_COMPAT_STATUS_OKAY(DT_DRV_COMPAT)
11181104
DT_INST_FOREACH_STATUS_OKAY(CDC_ACM_DT_DEVICE_DEFINE);
1119-
#else
1120-
UTIL_LISTIFY(CONFIG_USB_CDC_ACM_DEVICE_COUNT, CDC_ACM_DEVICE_DEFINE, _)
1121-
#endif

0 commit comments

Comments
 (0)