tests: drivers: can: api: fix misunderstood use of ESI flag

Fix the test for sending frames with the CAN_FRAME_ESI flag set. Sending
frames with this flag set in software is never allowed.

Fixes: 8023a58

Signed-off-by: Henrik Brix Andersen <[email protected]>

Author: henrikbrixandersen

tests/drivers/can/api/src/canfd.c

@@ -257,22 +257,20 @@ ZTEST(canfd, test_send_fd_dlc_out_of_range)
 }
 
 /**
- * @brief Test error when CAN FD Error State Indicator (ESI) is send without FD format flag (FDF).
+ * @brief Test error when CAN FD Error State Indicator (ESI) is set on transmit frame.
  *
- * CAN FD Error State Indicator (ESI) indicates that the transmitting node is
- * in error-passive state. Only valid in combination with CAN_FRAME_FDF.
+ * CAN FD Error State Indicator (ESI) indicates that the transmitting node is in error-passive
+ * state, but should never be set explicitly. Setting it is handled in the CAN controller hardware.
  */
 ZTEST(canfd, test_send_fd_incorrect_esi)
 {
 	struct can_frame frame = {
-		.flags = CAN_FRAME_ESI,
+		.flags = CAN_FRAME_FDF | CAN_FRAME_ESI,
 		.id = TEST_CAN_STD_ID_1,
 		.dlc = 0,
 	};
 	int err;
 
-	Z_TEST_SKIP_IFNDEF(CONFIG_RUNTIME_ERROR_CHECKS);
-
 	err = can_send(can_dev, &frame, TEST_SEND_TIMEOUT, NULL, NULL);
 	zassert_equal(err, -ENOTSUP, "wrong error on sending invalid frame (err %d)", err);
 }