tests: Bluetooth: llcp: cte_req: remove invalid rsp test

There is a test that verifies a behavior of CTE request control
procedure if receives LL_UNKNOWN_RSP. The expected behavior
is to terminate connection if that is response handling is
not implemented by a command. Other unexpected responses are
treated as new remote control procedures.

The CTE request has implemented handling of LL_UNKNOWN_RSP,
hence this particular test is no longer valid.

There is still open question how to handle other unexpected
reposne PDUs while waiting for LL_CTE_RSP. That is not defined
by BT 5.3. Core specification and not decided by community.

The test is removed to because it fails and blocks CI.

Signed-off-by: Piotr Pryga <[email protected]>

Author: ppryga-nordic

tests/bluetooth/controller/ctrl_cte_req/src/main.c

@@ -123,112 +123,6 @@ void test_cte_req_central_local(void)
 				  "Free CTX buffers %d", ctx_buffers_free());
 }
 
-/* Tests of invalid rsp execution of CTE Request Procedure */
-
-/* +-----+                     +-------+            +-----+
- * | UT  |                     | LL_A  |            | LT  |
- * +-----+                     +-------+            +-----+
- *    |                            |                   |
- *    | Start initiation           |                   |
- *    | CTE Request Proc.          |                   |
- *    |--------------------------->|                   |
- *    |                            |                   |
- *    |                            | LL_LE_CTE_REQ     |
- *    |                            |------------------>|
- *    |                            |                   |
- *    |                            | LL_<INVALID>_RSP  |
- *    |                            |<------------------|
- *    |                            |                   |
- * ~~~~~~~~~~~~~~~~~  TERMINATE CONNECTION ~~~~~~~~~~~~~~
- *    |                            |                   |
- *    |                            |                   |
- *    |                            |                   |
- */
-void test_cte_req_central_local_invalid_rsp(void)
-{
-	uint8_t err;
-	struct node_tx *tx;
-	struct pdu_data_llctrl_unknown_rsp unknown_rsp = {
-		.type = PDU_DATA_LLCTRL_TYPE_CTE_REQ
-	};
-	struct pdu_data_llctrl_reject_ind reject_ind = {
-		.error_code = BT_HCI_ERR_LL_PROC_COLLISION
-	};
-	struct pdu_data_llctrl_cte_req local_cte_req = {
-		.cte_type_req = BT_HCI_LE_AOA_CTE,
-		.min_cte_len_req = BT_HCI_LE_CTE_LEN_MIN,
-	};
-
-	/* Role */
-	test_set_role(&conn, BT_HCI_ROLE_PERIPHERAL);
-
-	/* Connect */
-	ull_cp_state_set(&conn, ULL_CP_CONNECTED);
-
-	/* Initiate an CTE Request Procedure */
-	err = ull_cp_cte_req(&conn, local_cte_req.min_cte_len_req, local_cte_req.cte_type_req);
-	zassert_equal(err, BT_HCI_ERR_SUCCESS, NULL);
-
-	/* Prepare */
-	event_prepare(&conn);
-
-	/* Tx Queue should have one LL Control PDU */
-	lt_rx(LL_CTE_REQ, &conn, &tx, &local_cte_req);
-	lt_rx_q_is_empty(&conn);
-
-	/* Rx */
-	lt_tx(LL_UNKNOWN_RSP, &conn, &unknown_rsp);
-
-	/* Done */
-	event_done(&conn);
-
-	/* There should not be a host notifications */
-	ut_rx_q_is_empty();
-
-	/* Release tx node */
-	ull_cp_release_tx(&conn, tx);
-
-	/* Termination 'triggered' */
-	zassert_equal(conn.llcp_terminate.reason_final, BT_HCI_ERR_LMP_PDU_NOT_ALLOWED,
-		      "Terminate reason %d", conn.llcp_terminate.reason_final);
-
-	/* Clear termination flag for subsequent test cycle */
-	conn.llcp_terminate.reason_final = 0;
-
-	zassert_equal(ctx_buffers_free(), test_ctx_buffers_cnt(),
-				  "Free CTX buffers %d", ctx_buffers_free());
-
-	/* Initiate another CTE Request Procedure */
-	err = ull_cp_cte_req(&conn, local_cte_req.min_cte_len_req, local_cte_req.cte_type_req);
-	zassert_equal(err, BT_HCI_ERR_SUCCESS, NULL);
-
-	/* Prepare */
-	event_prepare(&conn);
-
-	/* Tx Queue should have one LL Control PDU */
-	lt_rx(LL_CTE_REQ, &conn, &tx, &local_cte_req);
-	lt_rx_q_is_empty(&conn);
-
-	/* Rx */
-	lt_tx(LL_REJECT_IND, &conn, &reject_ind);
-
-	/* Done */
-	event_done(&conn);
-
-	/* There should not be a host notifications */
-	ut_rx_q_is_empty();
-
-	/* Release tx node */
-	ull_cp_release_tx(&conn, tx);
-
-	/* Termination 'triggered' */
-	zassert_equal(conn.llcp_terminate.reason_final, BT_HCI_ERR_LMP_PDU_NOT_ALLOWED,
-		      "Terminate reason %d", conn.llcp_terminate.reason_final);
-
-	zassert_equal(ctx_buffers_free(), test_ctx_buffers_cnt(),
-				  "Free CTX buffers %d", ctx_buffers_free());
-}
-
 /* +-----+                     +-------+            +-----+
  * | UT  |                     | LL_A  |            | LT  |
  * +-----+                     +-------+            +-----+
@@ -1599,8 +1493,6 @@ void test_main(void)
 	ztest_test_suite(
 		cte_req,
 		ztest_unit_test_setup_teardown(test_cte_req_central_local, setup, unit_test_noop),
-		ztest_unit_test_setup_teardown(test_cte_req_central_local_invalid_rsp, setup,
-					       unit_test_noop),
 		ztest_unit_test_setup_teardown(test_cte_req_peripheral_local, setup,
 					       unit_test_noop),
 		ztest_unit_test_setup_teardown(test_cte_req_central_remote, setup, unit_test_noop),