Skip to content

Commit 1eba6b1

Browse files
committed
drivers: mdio: stm32: don't mix HAL return value and errno
Correct mdio_stm32_read() and mdio_stm32_write() to return a valid errno instead of mixing HAL return values and errno return values. Signed-off-by: Etienne Carriere <[email protected]>
1 parent 5ac0a58 commit 1eba6b1

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/mdio/mdio_stm32_hal.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -38,8 +38,8 @@ static int mdio_stm32_read(const struct device *dev, uint8_t prtad,
3838
{
3939
struct mdio_stm32_data *const dev_data = dev->data;
4040
ETH_HandleTypeDef *heth = &dev_data->heth;
41+
HAL_StatusTypeDef ret;
4142
uint32_t read;
42-
int ret;
4343

4444
k_sem_take(&dev_data->sem, K_FOREVER);
4545

@@ -59,15 +59,15 @@ static int mdio_stm32_read(const struct device *dev, uint8_t prtad,
5959

6060
*data = read & ADIN1100_REG_VALUE_MASK;
6161

62-
return ret;
62+
return 0;
6363
}
6464

6565
static int mdio_stm32_write(const struct device *dev, uint8_t prtad,
6666
uint8_t regad, uint16_t data)
6767
{
6868
struct mdio_stm32_data *const dev_data = dev->data;
6969
ETH_HandleTypeDef *heth = &dev_data->heth;
70-
int ret;
70+
HAL_StatusTypeDef ret;
7171

7272
k_sem_take(&dev_data->sem, K_FOREVER);
7373

@@ -85,7 +85,7 @@ static int mdio_stm32_write(const struct device *dev, uint8_t prtad,
8585
return -EIO;
8686
}
8787

88-
return ret;
88+
return 0;
8989
}
9090

9191
#ifdef CONFIG_ETH_STM32_HAL_API_V1

0 commit comments

Comments
 (0)