Skip to content

Commit 1f8125a

Browse files
benwrsgalak
authored andcommitted
x86: fix irq_lock/unlock ordering bug
Memory accesses could be reordered before an irq_lock() or after an irq_unlock() without the memory barriers. See commit 15bc537 for the ARM fix for a complete description of the issue and fix. Change-Id: Ic92a6b33f62a938d2252d68eccc55a5fb07c9114 Signed-off-by: Benjamin Walsh <[email protected]>
1 parent acea241 commit 1f8125a

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

include/arch/x86/asm_inline_gcc.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -82,7 +82,7 @@ static ALWAYS_INLINE void _do_irq_unlock(void)
8282
{
8383
__asm__ volatile (
8484
"sti;\n\t"
85-
: :
85+
: : : "memory"
8686
);
8787
}
8888

0 commit comments

Comments
 (0)