drivers: uart: ambiq: fix incorrect uart tx ready status

AlessandroLuo · kartben · commit 1f95b06c95f0 · 2025-09-11T09:55:05.000+02:00
This commit fixes incorrect uart tx ready status

Signed-off-by: Hao Luo &lt;hluo@ambiq.com&gt;
diff --git a/drivers/serial/uart_ambiq.c b/drivers/serial/uart_ambiq.c
@@ -411,16 +411,18 @@ static int uart_ambiq_irq_tx_ready(const struct device *dev)
 {
 	const struct uart_ambiq_config *cfg = dev->config;
 	struct uart_ambiq_data *data = dev->data;
-	uint32_t status, flag = 0;
+	uint32_t status, flag, ier = 0;
 
 	if (!(UARTn(cfg->inst_idx)->CR & UART0_CR_TXE_Msk)) {
 		return false;
 	}
 
 	/* Check for TX interrupt status is set or TX FIFO is empty. */
-	am_hal_uart_interrupt_status_get(data->uart_handler, &status, true);
+	am_hal_uart_interrupt_status_get(data->uart_handler, &status, false);
 	am_hal_uart_flags_get(data->uart_handler, &flag);
-	return ((status & UART0_IES_TXRIS_Msk) || (flag & AM_HAL_UART_FR_TX_EMPTY));
+	am_hal_uart_interrupt_enable_get(data->uart_handler, &ier);
+	return ((ier & AM_HAL_UART_INT_TX) &&
+		((status & UART0_IES_TXRIS_Msk) || (flag & AM_HAL_UART_FR_TX_EMPTY)));
 }
 
 static void uart_ambiq_irq_rx_enable(const struct device *dev)

Original file line number	Diff line number	Diff line change
`@@ -411,16 +411,18 @@ static int uart_ambiq_irq_tx_ready(const struct device *dev)`
`411`	`411`	`{`
`412`	`412`	`const struct uart_ambiq_config *cfg = dev->config;`
`413`	`413`	`struct uart_ambiq_data *data = dev->data;`
`414`		`- uint32_t status, flag = 0;`
	`414`	`+ uint32_t status, flag, ier = 0;`
`415`	`415`
`416`	`416`	`if (!(UARTn(cfg->inst_idx)->CR & UART0_CR_TXE_Msk)) {`
`417`	`417`	`return false;`
`418`	`418`	`}`
`419`	`419`
`420`	`420`	`/* Check for TX interrupt status is set or TX FIFO is empty. */`
`421`		`- am_hal_uart_interrupt_status_get(data->uart_handler, &status, true);`
	`421`	`+ am_hal_uart_interrupt_status_get(data->uart_handler, &status, false);`
`422`	`422`	`am_hal_uart_flags_get(data->uart_handler, &flag);`
`423`		`- return ((status & UART0_IES_TXRIS_Msk) \|\| (flag & AM_HAL_UART_FR_TX_EMPTY));`
	`423`	`+ am_hal_uart_interrupt_enable_get(data->uart_handler, &ier);`
	`424`	`+ return ((ier & AM_HAL_UART_INT_TX) &&`
	`425`	`+ ((status & UART0_IES_TXRIS_Msk) \|\| (flag & AM_HAL_UART_FR_TX_EMPTY)));`
`424`	`426`	`}`
`425`	`427`
`426`	`428`	`static void uart_ambiq_irq_rx_enable(const struct device *dev)`