drivers: ethernet: phy: ksz8081: add support for interrupt mode

Enable Link-Up and Link-Down interrupts. On the interrupt handling
the monitor work is scheduled to update the link status and calling
corresponding callback routine.

Signed-off-by: Tony Han <[email protected]>

Author: TonyHan11

drivers/ethernet/phy/phy_microchip_ksz8081.c

@@ -31,6 +31,10 @@ LOG_MODULE_REGISTER(LOG_MODULE_NAME);
 #define PHY_MC_KSZ8081_OMSO_RMII_OVERRIDE_MASK	BIT(1)
 #define PHY_MC_KSZ8081_OMSO_MII_OVERRIDE_MASK	BIT(0)
 
+#define PHY_MC_KSZ8081_ICS_REG			0x1B
+#define PHY_MC_KSZ8081_ICS_LINK_DOWN_IE_MASK	BIT(10)
+#define PHY_MC_KSZ8081_ICS_LINK_UP_IE_MASK	BIT(8)
+
 #define PHY_MC_KSZ8081_CTRL2_REG		0x1F
 #define PHY_MC_KSZ8081_CTRL2_REF_CLK_SEL	BIT(7)
 
@@ -58,10 +62,18 @@ struct mc_ksz8081_config {
 #define KSZ8081_SILENCE_DEBUG_LOGS BIT(1)
 #define KSZ8081_LINK_STATE_VALID BIT(2)
 
+#define USING_INTERRUPT_GPIO							\
+		UTIL_OR(DT_ALL_INST_HAS_PROP_STATUS_OKAY(int_gpios),		\
+			UTIL_AND(DT_ANY_INST_HAS_PROP_STATUS_OKAY(int_gpios),	\
+				 (config->interrupt_gpio.port != NULL)))
+
 struct mc_ksz8081_data {
 	const struct device *dev;
 	struct phy_link_state state;
 	phy_callback_t cb;
+#if DT_ANY_INST_HAS_PROP_STATUS_OKAY(int_gpios)
+	struct gpio_callback gpio_callback;
+#endif
 	void *cb_data;
 	struct k_mutex mutex;
 	struct k_work_delayable phy_monitor_work;
@@ -111,6 +123,74 @@ static int phy_mc_ksz8081_write(const struct device *dev,
 	return 0;
 }
 
+#if !DT_ANY_INST_HAS_PROP_STATUS_OKAY(int_gpios)
+#define phy_mc_ksz8081_clear_interrupt(data) 0
+#else
+static int phy_mc_ksz8081_clear_interrupt(struct mc_ksz8081_data *data)
+{
+	const struct device *dev = data->dev;
+	const struct mc_ksz8081_config *config = dev->config;
+	uint32_t ics;
+	int ret;
+
+	/* Lock mutex */
+	ret = k_mutex_lock(&data->mutex, K_FOREVER);
+	if (ret < 0) {
+		LOG_ERR("PHY mutex lock error");
+		return ret;
+	}
+
+	/* Read/clear PHY interrupt status register */
+	ret = phy_mc_ksz8081_read(dev, PHY_MC_KSZ8081_ICS_REG, &ics);
+	if (ret < 0) {
+		LOG_ERR("Error reading phy (%d) interrupt status register", config->addr);
+	}
+
+	/* Unlock mutex */
+	k_mutex_unlock(&data->mutex);
+	return ret;
+}
+
+static int phy_mc_ksz8081_config_interrupt(const struct device *dev)
+{
+	struct mc_ksz8081_data *data = dev->data;
+	uint32_t ics;
+	int ret;
+
+	/* Read Interrupt Control/Status register to write back */
+	ret = phy_mc_ksz8081_read(dev, PHY_MC_KSZ8081_ICS_REG, &ics);
+	if (ret < 0) {
+		return ret;
+	}
+	ics |= PHY_MC_KSZ8081_ICS_LINK_UP_IE_MASK | PHY_MC_KSZ8081_ICS_LINK_DOWN_IE_MASK;
+
+	/* Write settings to Interrupt Control/Status register */
+	ret = phy_mc_ksz8081_write(dev, PHY_MC_KSZ8081_ICS_REG, ics);
+	if (ret < 0) {
+		return ret;
+	}
+
+	/* Clear interrupt */
+	ret = phy_mc_ksz8081_clear_interrupt(data);
+	if (ret < 0) {
+		return ret;
+	}
+
+	return ret;
+}
+
+static void phy_mc_ksz8081_interrupt_handler(const struct device *port, struct gpio_callback *cb,
+					     gpio_port_pins_t pins)
+{
+	struct mc_ksz8081_data *data = CONTAINER_OF(cb, struct mc_ksz8081_data, gpio_callback);
+	int ret = k_work_reschedule(&data->phy_monitor_work, K_NO_WAIT);
+
+	if (ret < 0) {
+		LOG_ERR("Failed to schedule monitor_work from ISR");
+	}
+}
+#endif /* DT_ANY_INST_HAS_PROP_STATUS_OKAY(int_gpios) */
+
 static int phy_mc_ksz8081_autonegotiate(const struct device *dev)
 {
 	const struct mc_ksz8081_config *config = dev->config;
@@ -142,7 +222,6 @@ static int phy_mc_ksz8081_autonegotiate(const struct device *dev)
 		goto done;
 	}
 
-	/* TODO change this to GPIO interrupt driven */
 	data->flags |= KSZ8081_SILENCE_DEBUG_LOGS;
 	do {
 		if (timeout-- == 0) {
@@ -432,6 +511,10 @@ static int phy_mc_ksz8081_cfg_link(const struct device *dev, enum phy_link_speed
 	/* Unlock mutex */
 	k_mutex_unlock(&data->mutex);
 
+	if (USING_INTERRUPT_GPIO) {
+		return ret;
+	}
+
 	/* Start monitoring */
 	k_work_reschedule(&data->phy_monitor_work,
 				K_MSEC(CONFIG_PHY_MONITOR_PERIOD));
@@ -465,6 +548,13 @@ static void phy_mc_ksz8081_monitor_work_handler(struct k_work *work)
 	bool turn_on_logs = false;
 	int rc = 0;
 
+	if (USING_INTERRUPT_GPIO) {
+		rc = phy_mc_ksz8081_clear_interrupt(data);
+		if (rc < 0) {
+			return;
+		}
+	}
+
 	if (!data->state.is_up) {
 		/* some overrides might need set on cold reset way late for some reason */
 		phy_mc_ksz8081_static_cfg(dev);
@@ -508,21 +598,50 @@ static void phy_mc_ksz8081_monitor_work_handler(struct k_work *work)
 		data->flags |= KSZ8081_SILENCE_DEBUG_LOGS;
 	}
 
-	/* TODO change this to GPIO interrupt driven */
+	if (USING_INTERRUPT_GPIO) {
+		return;
+	}
+
 	k_work_reschedule(&data->phy_monitor_work, K_MSEC(CONFIG_PHY_MONITOR_PERIOD));
 }
 
 #if DT_ANY_INST_HAS_PROP_STATUS_OKAY(int_gpios)
 static int ksz8081_init_int_gpios(const struct device *dev)
 {
 	const struct mc_ksz8081_config *config = dev->config;
+	struct mc_ksz8081_data *data = dev->data;
+	int ret;
 
 	if (config->interrupt_gpio.port == NULL) {
 		return 0;
 	}
 
-	/* Prevent NAND TREE mode */
-	return gpio_pin_configure_dt(&config->interrupt_gpio, GPIO_OUTPUT_ACTIVE);
+	/* Configure interrupt pin */
+	ret = gpio_pin_configure_dt(&config->interrupt_gpio, GPIO_INPUT);
+	if (ret < 0) {
+		goto done;
+	}
+
+	gpio_init_callback(&data->gpio_callback, phy_mc_ksz8081_interrupt_handler,
+			   BIT(config->interrupt_gpio.pin));
+
+	ret = gpio_add_callback_dt(&config->interrupt_gpio, &data->gpio_callback);
+	if (ret < 0) {
+		goto done;
+	}
+
+	ret = phy_mc_ksz8081_config_interrupt(dev);
+	if (ret < 0) {
+		goto done;
+	}
+
+	ret = gpio_pin_interrupt_configure_dt(&config->interrupt_gpio, GPIO_INT_EDGE_TO_ACTIVE);
+done:
+	if (ret < 0) {
+		LOG_ERR("PHY (%d) config interrupt failed", config->addr);
+	}
+
+	return ret;
 }
 #else
 #define ksz8081_init_int_gpios(dev) 0
@@ -574,7 +693,7 @@ static int phy_mc_ksz8081_init(const struct device *dev)
 	}
 
 	ret = ksz8081_init_int_gpios(dev);
-	if (ret) {
+	if (ret < 0) {
 		return ret;
 	}