secure_storage: its: store: settings: improve debug logging

tomi-font · fabiobaltieri · commit 23a6a785993e · 2024-12-17T11:34:42.000Z
Align the debug logging with that of the ZMS-based implementation.

Signed-off-by: Tomi Fontanilles &lt;tomi.fontanilles@nordicsemi.no&gt;
diff --git a/subsys/secure_storage/src/its/store/settings.c b/subsys/secure_storage/src/its/store/settings.c
@@ -20,7 +20,7 @@ static int init_settings_subsys(void)
 	const int ret = settings_subsys_init();
 
 	if (ret) {
-		LOG_DBG("Failed to initialize the settings subsystem. (%d)", ret);
+		LOG_DBG("Failed. (%d)", ret);
 	}
 	return ret;
 }
@@ -107,9 +107,7 @@ psa_status_t secure_storage_its_store_remove(secure_storage_its_uid_t uid)
 
 	make_name(uid, name);
 	ret = settings_delete(name);
-	if (ret) {
-		LOG_DBG("Failed to delete %s. (%d)", name, ret);
-		return PSA_ERROR_STORAGE_FAILURE;
-	}
-	return PSA_SUCCESS;
+
+	LOG_DBG("%s %s. (%d)", ret ? "Failed to delete" : "Deleted", name, ret);
+	return ret ? PSA_ERROR_STORAGE_FAILURE : PSA_SUCCESS;
 }

Original file line number	Diff line number	Diff line change
`@@ -20,7 +20,7 @@ static int init_settings_subsys(void)`
`20`	`20`	`const int ret = settings_subsys_init();`
`21`	`21`
`22`	`22`	`if (ret) {`
`23`		`- LOG_DBG("Failed to initialize the settings subsystem. (%d)", ret);`
	`23`	`+ LOG_DBG("Failed. (%d)", ret);`
`24`	`24`	`}`
`25`	`25`	`return ret;`
`26`	`26`	`}`
`@@ -107,9 +107,7 @@ psa_status_t secure_storage_its_store_remove(secure_storage_its_uid_t uid)`
`107`	`107`
`108`	`108`	`make_name(uid, name);`
`109`	`109`	`ret = settings_delete(name);`
`110`		`- if (ret) {`
`111`		`- LOG_DBG("Failed to delete %s. (%d)", name, ret);`
`112`		`- return PSA_ERROR_STORAGE_FAILURE;`
`113`		`- }`
`114`		`- return PSA_SUCCESS;`
	`110`	`+`
	`111`	`+ LOG_DBG("%s %s. (%d)", ret ? "Failed to delete" : "Deleted", name, ret);`
	`112`	`+ return ret ? PSA_ERROR_STORAGE_FAILURE : PSA_SUCCESS;`
`115`	`113`	`}`