Skip to content

Commit 2715357

Browse files
cfriedtcarlescufi
authored andcommitted
net: socket: socketpair: initialize after NULL check
Fixes #25788 Coverity-CID: 210581 Signed-off-by: Christopher Friedt <[email protected]>
1 parent fb9f6a4 commit 2715357

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

subsys/net/lib/sockets/socketpair.c

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1013,17 +1013,21 @@ static ssize_t spair_sendmsg(void *obj, const struct msghdr *msg,
10131013

10141014
int res;
10151015
size_t len = 0;
1016+
bool is_connected;
1017+
size_t avail;
1018+
bool is_nonblock;
10161019
struct spair *const spair = (struct spair *)obj;
1017-
const bool is_connected = sock_is_connected(spair);
1018-
const size_t avail = is_connected ? spair_write_avail(spair) : 0;
1019-
const bool is_nonblock = sock_is_nonblock(spair);
10201020

10211021
if (spair == NULL || msg == NULL) {
10221022
errno = EINVAL;
10231023
res = -1;
10241024
goto out;
10251025
}
10261026

1027+
is_connected = sock_is_connected(spair);
1028+
avail = is_connected ? spair_write_avail(spair) : 0;
1029+
is_nonblock = sock_is_nonblock(spair);
1030+
10271031
for (size_t i = 0; i < msg->msg_iovlen; ++i) {
10281032
/* check & msg->msg_iov[i]? */
10291033
/* check & msg->msg_iov[i].iov_base? */

0 commit comments

Comments
 (0)