Skip to content

Commit 28a0d90

Browse files
dcpleungcfriedt
authored andcommitted
tests: boards/intel_adsp/smoke: remove IPM test
This removes the IPM test from the intel_adsp smoke test. The IPM driver is not being used by SOF and is there simply for this test. The host IPC functionality is also being tested via test_host_ipc. The additional usage of mailbox in the test does not provide much value since the mailbox is shared memory between the DSP and the host. We would have bigger problems if the shared memory does not work properly. Removing the test is in preparation to removing the CAVS host IPM driver. That is also a preparation to rewrite the host IPC driver to the IPC API, and there is no need to maintain another host IPC driver that is not used by SOF. Signed-off-by: Daniel Leung <[email protected]>
1 parent e876dee commit 28a0d90

File tree

5 files changed

+3
-111
lines changed

5 files changed

+3
-111
lines changed

tests/boards/intel_adsp/smoke/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,4 +4,4 @@ cmake_minimum_required(VERSION 3.20.0)
44
find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
55
project(intel_adsp)
66

7-
target_sources(app PRIVATE src/main.c src/smpboot.c src/hostipc.c src/cpus.c src/ipm.c)
7+
target_sources(app PRIVATE src/main.c src/smpboot.c src/hostipc.c src/cpus.c)

tests/boards/intel_adsp/smoke/prj.conf

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,5 +2,3 @@ CONFIG_ZTEST=y
22
CONFIG_SMP=y
33
CONFIG_SMP_BOOT_DELAY=y
44
CONFIG_SCHED_CPU_MASK=y
5-
CONFIG_IPM=y
6-
CONFIG_IPM_CAVS_HOST=y

tests/boards/intel_adsp/smoke/src/ipm.c

Lines changed: 0 additions & 88 deletions
This file was deleted.

tests/boards/intel_adsp/smoke/src/main.c

Lines changed: 2 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -6,8 +6,6 @@
66
#include <stdlib.h>
77
#include "tests.h"
88

9-
intel_adsp_ipc_handler_t ipm_handler;
10-
119
static bool clock_msg(const struct device *dev, void *arg,
1210
uint32_t data, uint32_t ext_data)
1311
{
@@ -66,15 +64,6 @@ ZTEST(intel_adsp, test_vecbase_lock)
6664
}
6765
#endif
6866

69-
static void *intel_adsp_setup(void)
70-
{
71-
struct intel_adsp_ipc_data *devdata = INTEL_ADSP_IPC_HOST_DEV->data;
72-
73-
ipm_handler = devdata->handle_message;
74-
75-
return NULL;
76-
}
77-
7867
static void intel_adsp_teardown(void *data)
7968
{
8069
/* Wait a bit so the python script on host is ready to receive
@@ -85,7 +74,6 @@ static void intel_adsp_teardown(void *data)
8574
k_msleep(1000);
8675
}
8776

88-
ZTEST_SUITE(intel_adsp, NULL, intel_adsp_setup, NULL, NULL,
89-
intel_adsp_teardown);
77+
ZTEST_SUITE(intel_adsp, NULL, NULL, NULL, NULL, intel_adsp_teardown);
9078

91-
ZTEST_SUITE(intel_adsp_boot, NULL, intel_adsp_setup, NULL, NULL, NULL);
79+
ZTEST_SUITE(intel_adsp_boot, NULL, NULL, NULL, NULL, NULL);

tests/boards/intel_adsp/smoke/src/tests.h

Lines changed: 0 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -20,10 +20,4 @@
2020
zassert_true(i < 10000, "timeout waiting for %s", #expr); \
2121
} while (0)
2222

23-
/* Cached copy of the ipm_cavs_host driver's handler. We save it at
24-
* the start of the test because we want to do unit testing on the
25-
* underlying adsp_ipc device, then recover it later.
26-
*/
27-
extern intel_adsp_ipc_handler_t ipm_handler;
28-
2923
#endif /* ZEPHYR_TESTS_INTEL_ADSP_TESTS_H */

0 commit comments

Comments
 (0)