arc: fix off-by-one in _is_in_region()

Andrew Boie · nashif · commit 29095ac13502 · 2019-04-03T13:48:20.000-04:00
Similar issue to what was fixed earlier in the MPUv3 code. start + size should be <= r_addr_end. Fixes a problem where the last byte of an MPU region is incorrectly reported as out-of-bounds. Fixes: #15131 Signed-off-by: Andrew Boie <andrew.p.boie@intel.com>
diff --git a/arch/arc/core/mpu/arc_mpu_v2_internal.h b/arch/arc/core/mpu/arc_mpu_v2_internal.h
@@ -118,7 +118,7 @@ static inline bool _is_in_region(u32_t r_index, u32_t start, u32_t size)
 	r_size_lshift = (r_size_lshift & 0x3) | ((r_size_lshift >> 7) & 0x1C);
 	r_addr_end = r_addr_start  + (1 << (r_size_lshift + 1));
 
-	if (start >= r_addr_start && (start + size) < r_addr_end) {
+	if (start >= r_addr_start && (start + size) <= r_addr_end) {
 		return 1;
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -118,7 +118,7 @@ static inline bool _is_in_region(u32_t r_index, u32_t start, u32_t size)`
`118`	`118`	`r_size_lshift = (r_size_lshift & 0x3) \| ((r_size_lshift >> 7) & 0x1C);`
`119`	`119`	`r_addr_end = r_addr_start + (1 << (r_size_lshift + 1));`
`120`	`120`
`121`		`- if (start >= r_addr_start && (start + size) < r_addr_end) {`
	`121`	`+ if (start >= r_addr_start && (start + size) <= r_addr_end) {`
`122`	`122`	`return 1;`
`123`	`123`	`}`
`124`	`124`