drivers: modem: wnc14a2a: dont stop RSSI processing on error

mike-scott · galak · commit 29cc3b5aed0b · 2019-03-19T09:47:17.000-05:00
Instead of aborting on RSSI poll error, let's continue on and
reschedule the next RSSI poll.

This fixes an issue where RSSI polling would stop if for any reason
the modem doesn't fulfill an RSSI poll on time.

Signed-off-by: Michael Scott &lt;mike@foundries.io&gt;
diff --git a/drivers/modem/wncm14a2a.c b/drivers/modem/wncm14a2a.c
@@ -1298,7 +1298,6 @@ static void wncm14a2a_rssi_query_work(struct k_work *work)
 	ret = send_at_cmd(NULL, "AT%MEAS=\"23\"", MDM_CMD_TIMEOUT);
 	if (ret < 0) {
 		LOG_ERR("AT%%MEAS ret:%d", ret);
-		return;
 	}
 
 	/* re-start RSSI query work */

Original file line number	Diff line number	Diff line change
`@@ -1298,7 +1298,6 @@ static void wncm14a2a_rssi_query_work(struct k_work *work)`
`1298`	`1298`	`ret = send_at_cmd(NULL, "AT%MEAS=\"23\"", MDM_CMD_TIMEOUT);`
`1299`	`1299`	`if (ret < 0) {`
`1300`	`1300`	`LOG_ERR("AT%%MEAS ret:%d", ret);`
`1301`		`- return;`
`1302`	`1301`	`}`
`1303`	`1302`
`1304`	`1303`	`/* re-start RSSI query work */`