Skip to content

Commit 2d750d4

Browse files
committed
drivers: ssd16xx: Clean up ssd16xx_clear_cntlr_mem
Remove the optional call to ssd16xx_update_display() in ssd16xx_clear_cntlr_mem(). This doesn't really belong in that function and just adds a non-obvious boolean argument to the function. Signed-off-by: Andreas Sandberg <[email protected]>
1 parent 37bbae9 commit 2d750d4

File tree

1 file changed

+8
-9
lines changed

1 file changed

+8
-9
lines changed

drivers/display/ssd16xx.c

Lines changed: 8 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -605,8 +605,7 @@ static int ssd16xx_set_pixel_format(const struct device *dev,
605605
return -ENOTSUP;
606606
}
607607

608-
static int ssd16xx_clear_cntlr_mem(const struct device *dev, uint8_t ram_cmd,
609-
bool update)
608+
static int ssd16xx_clear_cntlr_mem(const struct device *dev, uint8_t ram_cmd)
610609
{
611610
const struct ssd16xx_config *config = dev->config;
612611
uint16_t panel_h = config->height / EPD_PANEL_NUMOF_ROWS_PER_PAGE;
@@ -655,10 +654,6 @@ static int ssd16xx_clear_cntlr_mem(const struct device *dev, uint8_t ram_cmd,
655654
}
656655
}
657656

658-
if (update) {
659-
return ssd16xx_update_display(dev);
660-
}
661-
662657
return 0;
663658
}
664659

@@ -873,13 +868,17 @@ static int ssd16xx_controller_init(const struct device *dev)
873868
return err;
874869
}
875870

876-
err = ssd16xx_clear_cntlr_mem(dev, SSD16XX_CMD_WRITE_RAM, true);
871+
err = ssd16xx_clear_cntlr_mem(dev, SSD16XX_CMD_WRITE_RAM);
872+
if (err < 0) {
873+
return err;
874+
}
875+
876+
err = ssd16xx_clear_cntlr_mem(dev, SSD16XX_CMD_WRITE_RED_RAM);
877877
if (err < 0) {
878878
return err;
879879
}
880880

881-
err = ssd16xx_clear_cntlr_mem(dev, SSD16XX_CMD_WRITE_RED_RAM,
882-
false);
881+
err = ssd16xx_update_display(dev);
883882
if (err < 0) {
884883
return err;
885884
}

0 commit comments

Comments
 (0)