drivers: usb: udc: stm32: use addr_before_status capability

Instead of snooping SETUP packets for SET_ADDRESS request to call the HAL
SetAddress() function manually, mark device with the addr_before_status
capability such that the UDC stack will call udc_stm32_set_address()
before submitting status by itself.

Signed-off-by: Mathieu Choplain <[email protected]>

Author: mathieuchopstm

drivers/usb/udc/udc_stm32.c

@@ -609,7 +609,6 @@ static void handle_msg_setup(struct udc_stm32_data *priv)
 {
 	struct usb_setup_packet *setup = (void *)priv->pcd.Setup;
 	const struct device *dev = priv->dev;
-	HAL_StatusTypeDef status;
 	struct net_buf *buf;
 	int err;
 
@@ -635,15 +634,6 @@ static void handle_msg_setup(struct udc_stm32_data *priv)
 
 	udc_ctrl_update_stage(dev, buf);
 
-	if ((setup->bmRequestType == 0) && (setup->bRequest == USB_SREQ_SET_ADDRESS)) {
-		/* HAL requires we set the address before submitting status */
-		status = HAL_PCD_SetAddress(&priv->pcd, setup->wValue);
-		if (status != HAL_OK) {
-			LOG_ERR("HAL_PCD_SetAddress() failed: %d", status);
-			__ASSERT_NO_MSG(0);
-		}
-	}
-
 	if (udc_ctrl_stage_is_data_out(dev)) {
 		/*  Allocate and feed buffer for data OUT stage */
 		err = udc_stm32_prep_out_ep0_rx(dev, udc_data_stage_length(buf));
@@ -1544,6 +1534,7 @@ static int udc_stm32_driver_init0(const struct device *dev)
 
 	data->caps.rwup = true;
 	data->caps.out_ack = false;
+	data->caps.addr_before_status = true;
 	data->caps.mps0 = UDC_MPS0_64;
 	if (cfg->selected_speed == PCD_SPEED_HIGH) {
 		data->caps.hs = true;