tests: spinlock: add some error test cases

Add some error test cases for spinlock, include:
1.Validate indentical spinlock cannot be used recursively.
2.Validate unlocking incorrect spinlock will trigger assertion.
3.Validate releasing incorrect spinlock will trigger assertion.

Signed-off-by: Enjia Mai <[email protected]>

Author: Enjia Mai

tests/kernel/spinlock/CMakeLists.txt

@@ -5,3 +5,4 @@ find_package(Zephyr REQUIRED HINTS $ENV{ZEPHYR_BASE})
 project(spinlock)
 
 target_sources(app PRIVATE src/main.c)
+target_sources(app PRIVATE src/spinlock_error_case.c)

tests/kernel/spinlock/prj.conf

@@ -1 +1,2 @@
 CONFIG_ZTEST=y
+CONFIG_SPIN_VALIDATE=y

tests/kernel/spinlock/src/main.c

@@ -174,11 +174,20 @@ void test_spinlock_mutual_exclusion(void)
 	zassert_true(!lock_runtime.locked, "Spinlock failed to unlock");
 }
 
+
+extern void test_spinlock_no_recursive(void);
+extern void test_spinlock_unlock_error(void);
+extern void test_spinlock_release_error(void);
+
+
 void test_main(void)
 {
 	ztest_test_suite(spinlock,
 			 ztest_unit_test(test_spinlock_basic),
 			 ztest_unit_test(test_spinlock_bounce),
-			 ztest_unit_test(test_spinlock_mutual_exclusion));
+			 ztest_unit_test(test_spinlock_mutual_exclusion),
+			 ztest_unit_test(test_spinlock_no_recursive),
+			 ztest_unit_test(test_spinlock_unlock_error),
+			 ztest_unit_test(test_spinlock_release_error));
 	ztest_run_test_suite(spinlock);
 }

tests/kernel/spinlock/src/spinlock_error_case.c

@@ -0,0 +1,121 @@
+/*
+ * Copyright (c) 2018 Intel Corporation.
+ *
+ * SPDX-License-Identifier: Apache-2.0
+ */
+#include <zephyr.h>
+#include <ztest.h>
+#include <spinlock.h>
+
+BUILD_ASSERT(CONFIG_MP_NUM_CPUS > 1);
+
+static struct k_spinlock lock;
+static struct k_spinlock mylock;
+static k_spinlock_key_t key;
+
+static ZTEST_DMEM volatile bool valid_assert;
+
+static inline void set_assert_valid(bool valid)
+{
+	valid_assert = valid;
+}
+
+static void action_after_assert_fail(void)
+{
+	k_spin_unlock(&lock, key);
+
+	ztest_test_pass();
+}
+
+#ifdef CONFIG_ASSERT_NO_FILE_INFO
+void assert_post_action(void)
+#else
+void assert_post_action(const char *file, unsigned int line)
+#endif
+{
+#ifndef CONFIG_ASSERT_NO_FILE_INFO
+	ARG_UNUSED(file);
+	ARG_UNUSED(line);
+#endif
+
+	printk("Caught an assert.\n");
+
+	if (valid_assert) {
+		valid_assert = false; /* reset back to normal */
+		printk("Assert error expected as part of test case.\n");
+
+		/* do some action after fatal error happened */
+		action_after_assert_fail();
+	} else {
+		printk("Assert failed was unexpected, aborting...\n");
+#ifdef CONFIG_USERSPACE
+	/* User threads aren't allowed to induce kernel panics; generate
+	 * an oops instead.
+	 */
+		if (_is_user_context()) {
+			k_oops();
+		}
+#endif
+		k_panic();
+	}
+}
+
+
+/**
+ * @brief Test spinlock cannot be recursive
+ *
+ * @details Validate using spinlock recursive will trigger assertion.
+ *
+ * @ingroup kernel_spinlock_tests
+ *
+ * @see k_spin_lock()
+ */
+void test_spinlock_no_recursive(void)
+{
+	k_spinlock_key_t re;
+
+	key = k_spin_lock(&lock);
+
+	set_assert_valid(true);
+	re = k_spin_lock(&lock);
+
+	ztest_test_fail();
+}
+
+/**
+ * @brief Test unlocking incorrect spinlock
+ *
+ * @details Validate unlocking incorrect spinlock will trigger assertion.
+ *
+ * @ingroup kernel_spinlock_tests
+ *
+ * @see k_spin_unlock()
+ */
+void test_spinlock_unlock_error(void)
+{
+	key = k_spin_lock(&lock);
+
+	set_assert_valid(true);
+	k_spin_unlock(&mylock, key);
+
+	ztest_test_fail();
+}
+
+/**
+ * @brief Test unlocking incorrect spinlock
+ *
+ * @details Validate unlocking incorrect spinlock will trigger assertion.
+ *
+ * @ingroup kernel_spinlock_tests
+ *
+ * @see k_spin_release()
+ */
+void test_spinlock_release_error(void)
+{
+	key = k_spin_lock(&lock);
+
+	set_assert_valid(true);
+	k_spin_release(&mylock);
+
+	ztest_test_fail();
+}