disk: sdhc: Remove logically dead code from spi sdhc driver

MaureenHelm · carlescufi · commit 3118c926c6e6 · 2019-11-18T13:53:02.000+01:00
We already returned out of the function if err is nonzero, therefore it
is impossible to reach this return statement.

Coverity-CID: 205612

Signed-off-by: Maureen Helm &lt;maureen.helm@nxp.com&gt;
diff --git a/subsys/disk/disk_access_spi_sdhc.c b/subsys/disk/disk_access_spi_sdhc.c
@@ -563,11 +563,6 @@ static int sdhc_spi_detect(struct sdhc_spi_data *data)
 				break;
 			}
 		} while (sdhc_retry_ok(&retry));
-
-		if (err != 0) {
-			/* Card never finished power-up */
-			return -ETIMEDOUT;
-		}
 	}
 
 	if ((ocr & SDHC_CCS) != 0U) {

Original file line number	Diff line number	Diff line change
`@@ -563,11 +563,6 @@ static int sdhc_spi_detect(struct sdhc_spi_data *data)`
`563`	`563`	`break;`
`564`	`564`	`}`
`565`	`565`	`} while (sdhc_retry_ok(&retry));`
`566`		`-`
`567`		`- if (err != 0) {`
`568`		`- /* Card never finished power-up */`
`569`		`- return -ETIMEDOUT;`
`570`		`- }`
`571`	`566`	`}`
`572`	`567`
`573`	`568`	`if ((ocr & SDHC_CCS) != 0U) {`