drivers: firmware: scmi: Rename SCMI_SHMEM_CHAN_STATUS_BUSY_BIT

yongxu-wang15 · yongxu-wang15 · commit 316c60081fc9 · 2025-10-22T11:03:36.000+08:00
Rename SCMI_SHMEM_CHAN_STATUS_BUSY_BIT to SCMI_SHMEM_CHAN_STATUS_FREE_BIT
for clearer semantics (bit set = channel free, bit clear = channel busy)

Signed-off-by: Yongxu Wang &lt;yongxu.wang@nxp.com&gt;
diff --git a/drivers/firmware/scmi/mailbox.c b/drivers/firmware/scmi/mailbox.c
@@ -74,7 +74,7 @@ static bool scmi_mbox_channel_is_free(const struct device *transport,
 	struct scmi_mbox_channel *mbox_chan = chan->data;
 
 	return scmi_shmem_channel_status(mbox_chan->shmem) &
-		SCMI_SHMEM_CHAN_STATUS_BUSY_BIT;
+		SCMI_SHMEM_CHAN_STATUS_FREE_BIT;
 }
 
 static int scmi_mbox_setup_chan(const struct device *transport,
diff --git a/drivers/firmware/scmi/shmem.c b/drivers/firmware/scmi/shmem.c
@@ -133,7 +133,7 @@ int scmi_shmem_write_message(const struct device *shmem, struct scmi_message *ms
 		return -EINVAL;
 	}
 
-	if (!(layout->chan_status & SCMI_SHMEM_CHAN_STATUS_BUSY_BIT)) {
+	if (!(layout->chan_status & SCMI_SHMEM_CHAN_STATUS_FREE_BIT)) {
 		return -EBUSY;
 	}
 
@@ -150,7 +150,7 @@ int scmi_shmem_write_message(const struct device *shmem, struct scmi_message *ms
 	}
 
 	/* done, mark channel as busy and proceed */
-	layout->chan_status &= ~SCMI_SHMEM_CHAN_STATUS_BUSY_BIT;
+	layout->chan_status &= ~SCMI_SHMEM_CHAN_STATUS_FREE_BIT;
 
 	return 0;
 }
diff --git a/include/zephyr/drivers/firmware/scmi/shmem.h b/include/zephyr/drivers/firmware/scmi/shmem.h
@@ -16,7 +16,7 @@
 #include <zephyr/arch/cpu.h>
 #include <errno.h>
 
-#define SCMI_SHMEM_CHAN_STATUS_BUSY_BIT BIT(0)
+#define SCMI_SHMEM_CHAN_STATUS_FREE_BIT BIT(0)
 #define SCMI_SHMEM_CHAN_FLAG_IRQ_BIT BIT(0)
 
 struct scmi_shmem_layout {

Original file line number	Diff line number	Diff line change
`@@ -74,7 +74,7 @@ static bool scmi_mbox_channel_is_free(const struct device *transport,`
`74`	`74`	`struct scmi_mbox_channel *mbox_chan = chan->data;`
`75`	`75`
`76`	`76`	`return scmi_shmem_channel_status(mbox_chan->shmem) &`
`77`		`- SCMI_SHMEM_CHAN_STATUS_BUSY_BIT;`
	`77`	`+ SCMI_SHMEM_CHAN_STATUS_FREE_BIT;`
`78`	`78`	`}`
`79`	`79`
`80`	`80`	`static int scmi_mbox_setup_chan(const struct device *transport,`
Original file line number	Diff line number	Diff line change
`@@ -133,7 +133,7 @@ int scmi_shmem_write_message(const struct device shmem, struct scmi_message ms`
`133`	`133`	`return -EINVAL;`
`134`	`134`	`}`
`135`	`135`
`136`		`- if (!(layout->chan_status & SCMI_SHMEM_CHAN_STATUS_BUSY_BIT)) {`
	`136`	`+ if (!(layout->chan_status & SCMI_SHMEM_CHAN_STATUS_FREE_BIT)) {`
`137`	`137`	`return -EBUSY;`
`138`	`138`	`}`
`139`	`139`
`@@ -150,7 +150,7 @@ int scmi_shmem_write_message(const struct device shmem, struct scmi_message ms`
`150`	`150`	`}`
`151`	`151`
`152`	`152`	`/* done, mark channel as busy and proceed */`
`153`		`- layout->chan_status &= ~SCMI_SHMEM_CHAN_STATUS_BUSY_BIT;`
	`153`	`+ layout->chan_status &= ~SCMI_SHMEM_CHAN_STATUS_FREE_BIT;`
`154`	`154`
`155`	`155`	`return 0;`
`156`	`156`	`}`