Apply suggestions from code review

Co-authored-by: Alexander Wachter <[email protected]>

Author: sebhub

drivers/can/can_mchp_mss.c

@@ -366,9 +366,9 @@ static int mss_can_send(const struct device *dev, const struct can_frame *frame,
 		 * Since we were able to take the transmit semaphore, at least
 		 * one buffer is not used.
 		 */
-		uint32_t tx_used = data->tx_used;
-		uint32_t index = find_msb_set(~tx_used) - 1;
-		uintptr_t tx_msg_base = reg_base + MSS_CAN_TX_MSG(index);
+		const uint32_t tx_used = data->tx_used;
+		const uint32_t index = find_msb_set(~tx_used) - 1;
+		const uintptr_t tx_msg_base = reg_base + MSS_CAN_TX_MSG(index);
 
 		/* Request transmission of the frame */
 		sys_write32(frame->id << id_shift, tx_msg_base + MSS_CAN_TX_MSG_ID);
@@ -423,8 +423,8 @@ static int mss_can_add_rx_filter(const struct device *dev, can_rx_callback_t cal
 
 	/* Search for the first available receive message buffer */
 	do {
-		uintptr_t rx_msg_base = reg_base + MSS_CAN_RX_MSG(index);
-		uint32_t rx_msg_ctrl_cmd = sys_read32(rx_msg_base + MSS_CAN_RX_MSG_CTRL_CMD);
+		const uintptr_t rx_msg_base = reg_base + MSS_CAN_RX_MSG(index);
+		const uint32_t rx_msg_ctrl_cmd = sys_read32(rx_msg_base + MSS_CAN_RX_MSG_CTRL_CMD);
 
 		if ((rx_msg_ctrl_cmd & MSS_CAN_RX_MSG_CTRL_CMD_RXBUFFEREBL) == 0) {
 			break;
@@ -436,7 +436,7 @@ static int mss_can_add_rx_filter(const struct device *dev, can_rx_callback_t cal
 	int filter_id;
 
 	if (index != MSS_CAN_RX_MSG_COUNT) {
-		uintptr_t rx_msg_base = reg_base + MSS_CAN_RX_MSG(index);
+		const uintptr_t rx_msg_base = reg_base + MSS_CAN_RX_MSG(index);
 		uint32_t rx_msg_ctrl_cmd = MSS_CAN_RX_MSG_CTRL_CMD_RXBUFFEREBL |
 					   MSS_CAN_RX_MSG_CTRL_CMD_RX_INT_ENABLE |
 					   MSS_CAN_RX_MSG_CTRL_CMD_WPNL |