Skip to content

Commit 3426050

Browse files
gmarullcarlescufi
authored andcommitted
device: Z_DEVICE_STATE_DEFINE doesn't need node_id
The macro is not using node_id, so remove it from the arg list. Do the same for I2C/CAN "sub-macros". Signed-off-by: Gerard Marull-Paretas <[email protected]>
1 parent 92ad394 commit 3426050

File tree

5 files changed

+11
-12
lines changed

5 files changed

+11
-12
lines changed

include/zephyr/device.h

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -154,7 +154,7 @@ typedef int16_t device_handle_t;
154154
*/
155155
#define DEVICE_DEFINE(dev_id, name, init_fn, pm, data, config, level, prio, \
156156
api) \
157-
Z_DEVICE_STATE_DEFINE(DT_INVALID_NODE, dev_id); \
157+
Z_DEVICE_STATE_DEFINE(dev_id); \
158158
Z_DEVICE_DEFINE(DT_INVALID_NODE, dev_id, name, init_fn, pm, data, \
159159
config, level, prio, api, \
160160
&Z_DEVICE_STATE_NAME(dev_id))
@@ -216,7 +216,7 @@ typedef int16_t device_handle_t;
216216
*/
217217
#define DEVICE_DT_DEFINE(node_id, init_fn, pm, data, config, level, prio, api, \
218218
...) \
219-
Z_DEVICE_STATE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id)); \
219+
Z_DEVICE_STATE_DEFINE(Z_DEVICE_DT_DEV_NAME(node_id)); \
220220
Z_DEVICE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id), \
221221
DEVICE_DT_NAME(node_id), init_fn, pm, data, config, \
222222
level, prio, api, \
@@ -807,10 +807,9 @@ static inline bool z_impl_device_is_ready(const struct device *dev)
807807
/**
808808
* @brief Utility macro to define and initialize the device state.
809809
*
810-
* @param node_id Devicetree node id of the device.
811810
* @param dev_id Device identifier.
812811
*/
813-
#define Z_DEVICE_STATE_DEFINE(node_id, dev_id) \
812+
#define Z_DEVICE_STATE_DEFINE(dev_id) \
814813
static struct device_state Z_DEVICE_STATE_NAME(dev_id) \
815814
__attribute__((__section__(".z_devstate")))
816815

include/zephyr/drivers/can.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -559,7 +559,7 @@ struct can_device_state {
559559
/**
560560
* @brief Define a statically allocated and section assigned CAN device state
561561
*/
562-
#define Z_CAN_DEVICE_STATE_DEFINE(node_id, dev_id) \
562+
#define Z_CAN_DEVICE_STATE_DEFINE(dev_id) \
563563
static struct can_device_state Z_DEVICE_STATE_NAME(dev_id) \
564564
__attribute__((__section__(".z_devstate")))
565565

@@ -604,7 +604,7 @@ struct can_device_state {
604604
*/
605605
#define CAN_DEVICE_DT_DEFINE(node_id, init_fn, pm, data, config, level, \
606606
prio, api, ...) \
607-
Z_CAN_DEVICE_STATE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id)); \
607+
Z_CAN_DEVICE_STATE_DEFINE(Z_DEVICE_DT_DEV_NAME(node_id)); \
608608
Z_CAN_INIT_FN(Z_DEVICE_DT_DEV_NAME(node_id), init_fn) \
609609
Z_DEVICE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id), \
610610
DEVICE_DT_NAME(node_id), \

include/zephyr/drivers/i2c.h

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ static inline void i2c_xfer_stats(const struct device *dev, struct i2c_msg *msgs
457457
/**
458458
* @brief Define a statically allocated and section assigned i2c device state
459459
*/
460-
#define Z_I2C_DEVICE_STATE_DEFINE(node_id, dev_id) \
460+
#define Z_I2C_DEVICE_STATE_DEFINE(dev_id) \
461461
static struct i2c_device_state Z_DEVICE_STATE_NAME(dev_id) \
462462
__attribute__((__section__(".z_devstate")))
463463

@@ -509,7 +509,7 @@ static inline void i2c_xfer_stats(const struct device *dev, struct i2c_msg *msgs
509509
*/
510510
#define I2C_DEVICE_DT_DEFINE(node_id, init_fn, pm, data, config, level, \
511511
prio, api, ...) \
512-
Z_I2C_DEVICE_STATE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id)); \
512+
Z_I2C_DEVICE_STATE_DEFINE(Z_DEVICE_DT_DEV_NAME(node_id)); \
513513
Z_I2C_INIT_FN(Z_DEVICE_DT_DEV_NAME(node_id), init_fn) \
514514
Z_DEVICE_DEFINE(node_id, Z_DEVICE_DT_DEV_NAME(node_id), \
515515
DEVICE_DT_NAME(node_id), \

include/zephyr/net/ethernet.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -837,7 +837,7 @@ static inline bool net_eth_get_vlan_status(struct net_if *iface)
837837
#if defined(CONFIG_NET_VLAN)
838838
#define Z_ETH_NET_DEVICE_INIT(node_id, dev_id, name, init_fn, pm, data, \
839839
config, prio, api, mtu) \
840-
Z_DEVICE_STATE_DEFINE(node_id, dev_id); \
840+
Z_DEVICE_STATE_DEFINE(dev_id); \
841841
Z_DEVICE_DEFINE(node_id, dev_id, name, init_fn, pm, data, \
842842
config, POST_KERNEL, prio, api, \
843843
&Z_DEVICE_STATE_NAME(dev_id)); \

include/zephyr/net/net_if.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2316,7 +2316,7 @@ struct net_if_api {
23162316

23172317
#define Z_NET_DEVICE_INIT(node_id, dev_id, name, init_fn, pm, data, \
23182318
config, prio, api, l2, l2_ctx_type, mtu) \
2319-
Z_DEVICE_STATE_DEFINE(node_id, dev_id); \
2319+
Z_DEVICE_STATE_DEFINE(dev_id); \
23202320
Z_DEVICE_DEFINE(node_id, dev_id, name, init_fn, pm, data, \
23212321
config, POST_KERNEL, prio, api, \
23222322
&Z_DEVICE_STATE_NAME(dev_id)); \
@@ -2385,7 +2385,7 @@ struct net_if_api {
23852385
#define Z_NET_DEVICE_INIT_INSTANCE(node_id, dev_id, name, instance, \
23862386
init_fn, pm, data, config, prio, \
23872387
api, l2, l2_ctx_type, mtu) \
2388-
Z_DEVICE_STATE_DEFINE(node_id, dev_id); \
2388+
Z_DEVICE_STATE_DEFINE(dev_id); \
23892389
Z_DEVICE_DEFINE(node_id, dev_id, name, init_fn, pm, data, \
23902390
config, POST_KERNEL, prio, api, \
23912391
&Z_DEVICE_STATE_NAME(dev_id)); \
@@ -2467,7 +2467,7 @@ struct net_if_api {
24672467

24682468
#define Z_NET_DEVICE_OFFLOAD_INIT(node_id, dev_id, name, init_fn, pm, \
24692469
data, config, prio, api, mtu) \
2470-
Z_DEVICE_STATE_DEFINE(node_id, dev_id); \
2470+
Z_DEVICE_STATE_DEFINE(dev_id); \
24712471
Z_DEVICE_DEFINE(node_id, dev_id, name, init_fn, pm, data, \
24722472
config, POST_KERNEL, prio, api, \
24732473
&Z_DEVICE_STATE_NAME(dev_id)); \

0 commit comments

Comments
 (0)