drivers: sensor: ti: ina230: Add support for INA236

This commit adds support for INA236 into the existing INA230 driver.
These two chips are similar enough to share most of the code.
The device can be defined the same way as INA230 and we only have
the extra option to select the high-precision mode.

```
ina236: ina236@40 {
		status = "okay";
		compatible = "ti,ina236", "ti,ina230";
		reg = <0x40>;
		adc-mode = "Bus and shunt voltage continuous";
		vbus-conversion-time-us = <1100>;
		vshunt-conversion-time-us = <1100>;
		avg-count = <1>;
		current-lsb-microamps = <1000>;
		rshunt-micro-ohms = <15000>;
		alert-gpios = <&gpiod 0 GPIO_ACTIVE_LOW>;
		high-precision;
	};
```

Signed-off-by: Tomáš Juřena <[email protected]>

Author: jurenat

drivers/sensor/ti/ina23x/Kconfig

@@ -5,7 +5,7 @@
 config INA23X
 	bool "INA23X Current and Power Monitor"
 	default y
-	depends on DT_HAS_TI_INA230_ENABLED || DT_HAS_TI_INA237_ENABLED
+	depends on DT_HAS_TI_INA230_ENABLED || DT_HAS_TI_INA236_ENABLED || DT_HAS_TI_INA237_ENABLED
 	select I2C
 	help
 	  Enable driver for INA23X Current and Power Monitor.
@@ -15,9 +15,9 @@ if INA23X
 config INA230
 	bool "INA230"
 	default y
-	depends on DT_HAS_TI_INA230_ENABLED
+	depends on DT_HAS_TI_INA230_ENABLED || DT_HAS_TI_INA236_ENABLED
 	help
-	  Enable driver for INA230/INA231.
+	  Enable driver for INA230/INA231/INA236.
 
 config INA237
 	bool "INA237"

drivers/sensor/ti/ina23x/ina230.c

@@ -5,8 +5,6 @@
  * SPDX-License-Identifier: Apache-2.0
  */
 
-#define DT_DRV_COMPAT ti_ina230
-
 #include "ina230.h"
 #include "ina23x_common.h"
 
@@ -20,9 +18,11 @@ LOG_MODULE_REGISTER(INA230, CONFIG_SENSOR_LOG_LEVEL);
 
 /** @brief The LSB value for the bus voltage register, in microvolts/LSB. */
 #define INA230_BUS_VOLTAGE_UV_LSB 1250U
+#define INA236_BUS_VOLTAGE_UV_LSB 1600U
 
 /** @brief The scaling for the power register. */
 #define INA230_POWER_SCALING 25
+#define INA236_POWER_SCALING 32
 
 static int ina230_channel_get(const struct device *dev, enum sensor_channel chan,
 			      struct sensor_value *val)
@@ -34,7 +34,7 @@ static int ina230_channel_get(const struct device *dev, enum sensor_channel chan
 
 	switch (chan) {
 	case SENSOR_CHAN_VOLTAGE:
-		bus_uv = data->bus_voltage * INA230_BUS_VOLTAGE_UV_LSB;
+		bus_uv = data->bus_voltage * config->uv_lsb;
 
 		/* convert to fractional volts (units for voltage channel) */
 		val->val1 = bus_uv / 1000000U;
@@ -51,7 +51,7 @@ static int ina230_channel_get(const struct device *dev, enum sensor_channel chan
 		break;
 
 	case SENSOR_CHAN_POWER:
-		power_uw = data->power * INA230_POWER_SCALING * config->current_lsb;
+		power_uw = data->power * config->power_scale * config->current_lsb;
 
 		/* convert to fractional watts */
 		val->val1 = (int32_t)(power_uw / 1000000U);
@@ -248,23 +248,32 @@ static const struct sensor_driver_api ina230_driver_api = {
 #define INA230_CFG_IRQ(inst)
 #endif /* CONFIG_INA230_TRIGGER */
 
-#define INA230_DRIVER_INIT(inst)                                                                   \
+#define INA230_DRIVER_INIT(inst, type)                                                             \
 	static struct ina230_data drv_data_##inst;                                                 \
-	static const struct ina230_config drv_config_##inst = {                                    \
+	static const struct ina230_config drv_config_##type##inst = {                              \
 		.bus = I2C_DT_SPEC_INST_GET(inst),                                                 \
-		.config = DT_INST_PROP(inst, config) |                           \
-			(DT_INST_ENUM_IDX(inst, avg_count) << 9) |                   \
-			(DT_INST_ENUM_IDX(inst, vbus_conversion_time_us) << 6) |     \
-			(DT_INST_ENUM_IDX(inst, vshunt_conversion_time_us) << 3) |   \
-			DT_INST_ENUM_IDX(inst, adc_mode),                            \
+		.config = (DT_INST_PROP_OR(inst, high_precision, 0) << 12) |                       \
+			  DT_INST_PROP(inst, config) | (DT_INST_ENUM_IDX(inst, avg_count) << 9) |  \
+			  (DT_INST_ENUM_IDX(inst, vbus_conversion_time_us) << 6) |                 \
+			  (DT_INST_ENUM_IDX(inst, vshunt_conversion_time_us) << 3) |               \
+			  DT_INST_ENUM_IDX(inst, adc_mode),                                        \
 		.current_lsb = DT_INST_PROP(inst, current_lsb_microamps),                          \
-		.cal = (uint16_t)((INA230_CAL_SCALING * 10000000ULL) /                             \
-				  ((uint64_t)DT_INST_PROP(inst, current_lsb_microamps) *           \
-				   DT_INST_PROP(inst, rshunt_micro_ohms))),                        \
+		.uv_lsb = type##_BUS_VOLTAGE_UV_LSB,                                               \
+		.power_scale = type##_POWER_SCALING,                                               \
+		.cal = (uint16_t)(((INA230_CAL_SCALING * 10000000ULL) /                            \
+				   ((uint64_t)DT_INST_PROP(inst, current_lsb_microamps) *          \
+				    DT_INST_PROP(inst, rshunt_micro_ohms))) >>                     \
+				  (DT_INST_PROP_OR(inst, high_precision, 0) << 1)),                \
 		COND_CODE_1(DT_INST_NODE_HAS_PROP(inst, alert_gpios), (INA230_CFG_IRQ(inst)),      \
-			    ())};                                                                  \
+			    ())};   \
 	SENSOR_DEVICE_DT_INST_DEFINE(inst, &ina230_init, NULL, &drv_data_##inst,                   \
-				     &drv_config_##inst, POST_KERNEL, CONFIG_SENSOR_INIT_PRIORITY, \
-				     &ina230_driver_api);
+				     &drv_config_##type##inst, POST_KERNEL,                        \
+				     CONFIG_SENSOR_INIT_PRIORITY, &ina230_driver_api);
+
+#undef DT_DRV_COMPAT
+#define DT_DRV_COMPAT ti_ina230
+DT_INST_FOREACH_STATUS_OKAY_VARGS(INA230_DRIVER_INIT, INA230)
 
-DT_INST_FOREACH_STATUS_OKAY(INA230_DRIVER_INIT)
+#undef DT_DRV_COMPAT
+#define DT_DRV_COMPAT ti_ina236
+DT_INST_FOREACH_STATUS_OKAY_VARGS(INA230_DRIVER_INIT, INA236)

drivers/sensor/ti/ina23x/ina230.h

@@ -23,14 +23,16 @@
 #include <zephyr/kernel.h>
 #endif
 
-#define INA230_REG_CONFIG     0x00
-#define INA230_REG_SHUNT_VOLT 0x01
-#define INA230_REG_BUS_VOLT   0x02
-#define INA230_REG_POWER      0x03
-#define INA230_REG_CURRENT    0x04
-#define INA230_REG_CALIB      0x05
-#define INA230_REG_MASK       0x06
-#define INA230_REG_ALERT      0x07
+#define INA230_REG_CONFIG          0x00
+#define INA230_REG_SHUNT_VOLT      0x01
+#define INA230_REG_BUS_VOLT        0x02
+#define INA230_REG_POWER           0x03
+#define INA230_REG_CURRENT         0x04
+#define INA230_REG_CALIB           0x05
+#define INA230_REG_MASK            0x06
+#define INA230_REG_ALERT           0x07
+#define INA236_REG_MANUFACTURER_ID 0x3E
+#define INA236_REG_DEVICE_ID       0x3F
 
 struct ina230_data {
 	const struct device *dev;
@@ -43,25 +45,26 @@ struct ina230_data {
 	struct k_work work;
 	sensor_trigger_handler_t handler_alert;
 	const struct sensor_trigger *trig_alert;
-#endif  /* CONFIG_INA230_TRIGGER */
+#endif /* CONFIG_INA230_TRIGGER */
 };
 
 struct ina230_config {
 	struct i2c_dt_spec bus;
 	uint16_t config;
 	uint32_t current_lsb;
 	uint16_t cal;
+	uint8_t power_scale;
+	uint32_t uv_lsb;
 #ifdef CONFIG_INA230_TRIGGER
 	bool trig_enabled;
 	uint16_t mask;
 	const struct gpio_dt_spec alert_gpio;
 	uint16_t alert_limit;
-#endif  /* CONFIG_INA230_TRIGGER */
+#endif /* CONFIG_INA230_TRIGGER */
 };
 
 int ina230_trigger_mode_init(const struct device *dev);
-int ina230_trigger_set(const struct device *dev,
-		       const struct sensor_trigger *trig,
+int ina230_trigger_set(const struct device *dev, const struct sensor_trigger *trig,
 		       sensor_trigger_handler_t handler);
 
 #endif /* ZEPHYR_DRIVERS_SENSOR_INA23X_INA230_H_ */

dts/bindings/sensor/ti,ina230.yaml

@@ -6,7 +6,7 @@
 #
 
 description: |
-    TI INA230 and INA231 Bidirectional Current and Power Monitor.
+    TI INA230, INA231 and INA236 Bidirectional Current and Power Monitor.
     The <zephyr/dt-bindings/sensor/ina230.h> file should be included in the
     DeviceTree and it provides macro that can be used for initializing the
     configuration register.

dts/bindings/sensor/ti,ina236.yaml

@@ -0,0 +1,21 @@
+#
+# Copyright 2024 Tomas Jurena
+#
+# SPDX-License-Identifier: Apache-2.0
+#
+
+description: |
+    TI INA236 Bidirectional Current and Power Monitor.
+    The <zephyr/dt-bindings/sensor/ina230.h> file should be included in the
+    DeviceTree and it provides macro that can be used for initializing the
+    configuration register.
+
+compatible: "ti,ina236"
+
+include: ti,ina230.yaml
+
+properties:
+  high-precision:
+    type: boolean
+    description: |
+      Enable high precision mode (4x the resolution).