Skip to content

Commit 374629a

Browse files
henrikbrixandersengalak
authored andcommitted
canbus: isotp: remove unused work queue
Remove unused local work queue. Fixes #34862 Signed-off-by: Henrik Brix Andersen <[email protected]>
1 parent 1470ef6 commit 374629a

File tree

2 files changed

+0
-33
lines changed

2 files changed

+0
-33
lines changed

subsys/canbus/isotp/Kconfig

Lines changed: 0 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -63,20 +63,6 @@ config ISOTP_ENABLE_TX_PADDING
6363
Add padding bytes 0xCC (as recommended by Bosch) if the PDU payload
6464
does not fit exactly into the CAN frame.
6565

66-
config ISOTP_WORKQUEUE_PRIO
67-
int "Priority level of the RX and TX work queue"
68-
default 2
69-
help
70-
This value defines the priority level of the work queue thread that
71-
handles flow control, consecutive sending, receiving and callbacks.
72-
73-
config ISOTP_WORKQ_STACK_SIZE
74-
int "Work queue stack size"
75-
default 256
76-
help
77-
This value defines the stack size of the work queue thread that
78-
handles flow control, consecutive sending, receiving and callbacks.
79-
8066
config ISOTP_RX_BUF_COUNT
8167
int "Number of data buffers for receiving data"
8268
default 4

subsys/canbus/isotp/isotp.c

Lines changed: 0 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -39,9 +39,6 @@ NET_BUF_POOL_VAR_DEFINE(isotp_tx_pool, CONFIG_ISOTP_TX_BUF_COUNT,
3939
CONFIG_ISOTP_BUF_TX_DATA_POOL_SIZE, NULL);
4040
#endif
4141

42-
K_KERNEL_STACK_DEFINE(tx_stack, CONFIG_ISOTP_WORKQ_STACK_SIZE);
43-
static struct k_work_q isotp_workq;
44-
4542
static void receive_state_machine(struct isotp_recv_ctx *ctx);
4643

4744
/*
@@ -1329,19 +1326,3 @@ int isotp_send_buf(const struct device *can_dev,
13291326
}
13301327
#endif /*CONFIG_ISOTP_USE_TX_BUF*/
13311328
#endif /*CONFIG_ISOTP_ENABLE_CONTEXT_BUFFERS*/
1332-
1333-
static int isotp_workq_init(const struct device *dev)
1334-
{
1335-
ARG_UNUSED(dev);
1336-
1337-
LOG_DBG("Starting workqueue");
1338-
k_work_queue_start(&isotp_workq, tx_stack,
1339-
K_KERNEL_STACK_SIZEOF(tx_stack),
1340-
CONFIG_ISOTP_WORKQUEUE_PRIO, NULL);
1341-
1342-
k_thread_name_set(&isotp_workq.thread, "isotp_work");
1343-
1344-
return 0;
1345-
}
1346-
1347-
SYS_INIT(isotp_workq_init, POST_KERNEL, CONFIG_APPLICATION_INIT_PRIORITY);

0 commit comments

Comments
 (0)