Skip to content

Commit 3824024

Browse files
teburdnashif
authored andcommitted
dma: hda link driver fixups
Fixes configured DMA direction for HDA link in/out drivers. Adjusts the number of channels for link in/link out to safe value that seems to work on all tested parts. Signed-off-by: Tom Burdick <[email protected]>
1 parent afb156a commit 3824024

File tree

4 files changed

+11
-11
lines changed

4 files changed

+11
-11
lines changed

drivers/dma/dma_cavs_hda_link_in.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@ static const struct dma_driver_api cavs_hda_dma_link_in_api = {
2626
static const struct cavs_hda_dma_cfg cavs_hda_dma##inst##_config = { \
2727
.base = DT_INST_REG_ADDR(inst), \
2828
.dma_channels = DT_INST_PROP(inst, dma_channels), \
29-
.direction = MEMORY_TO_HOST \
29+
.direction = PERIPHERAL_TO_MEMORY \
3030
}; \
3131
\
3232
static struct cavs_hda_dma_data cavs_hda_dma##inst##_data = {}; \

drivers/dma/dma_cavs_hda_link_out.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -26,8 +26,8 @@ static const struct dma_driver_api cavs_hda_dma_link_out_api = {
2626
static const struct cavs_hda_dma_cfg cavs_hda_dma##inst##_config = { \
2727
.base = DT_INST_REG_ADDR(inst), \
2828
.dma_channels = DT_INST_PROP(inst, dma_channels), \
29-
.direction = MEMORY_TO_HOST \
30-
}; \
29+
.direction = MEMORY_TO_PERIPHERAL \
30+
}; \
3131
\
3232
static struct cavs_hda_dma_data cavs_hda_dma##inst##_data = {}; \
3333
\

dts/xtensa/intel/intel_cavs.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -36,22 +36,22 @@
3636
compatible = "intel,cavs-hda-link-out";
3737
#dma-cells = <1>;
3838
reg = <0x00072400 0x40>;
39-
dma-channels = <9>;
39+
dma-channels = <4>;
4040
dma-buf-alignment = <128>;
4141
label = "HDA_LINK_OUT";
4242

43-
status = "disabled";
43+
status = "okay";
4444
};
4545

4646
hda_link_in: dma@72600 {
4747
compatible = "intel,cavs-hda-link-in";
4848
#dma-cells = <1>;
4949
reg = <0x00072600 0x40>;
50-
dma-channels = <7>;
50+
dma-channels = <4>;
5151
dma-buf-alignment = <128>;
5252
label = "HDA_LINK_IN";
5353

54-
status = "disabled";
54+
status = "okay";
5555
};
5656

5757
hda_host_out: dma@72800 {

dts/xtensa/intel/intel_cavs15.dtsi

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -163,22 +163,22 @@
163163
compatible = "intel,cavs-hda-link-out";
164164
#dma-cells = <1>;
165165
reg = <0x00002400 0x40>;
166-
dma-channels = <6>;
166+
dma-channels = <2>;
167167
dma-buf-alignment = <128>;
168168
label = "HDA_LINK_OUT";
169169

170-
status = "disabled";
170+
status = "okay";
171171
};
172172

173173
hda_link_in: dma@2600 {
174174
compatible = "intel,cavs-hda-link-in";
175175
#dma-cells = <1>;
176176
reg = <0x00002600 0x40>;
177-
dma-channels = <7>;
177+
dma-channels = <2>;
178178
dma-buf-alignment = <128>;
179179
label = "HDA_LINK_IN";
180180

181-
status = "disabled";
181+
status = "okay";
182182
};
183183

184184
hda_host_out: dma@2800 {

0 commit comments

Comments
 (0)