drivers: sensor: icp201xx: fix channel check logic

kartben · kartben · commit 39a65c0be2f5 · 2025-04-08T10:48:49.000+02:00
Update the channel validation logic to properly check channel against
SENSOR_CHAN_ALTITUDE.

Signed-off-by: Benjamin Cabé &lt;benjamin@zephyrproject.org&gt;
diff --git a/drivers/sensor/tdk/icp201xx/icp201xx_drv.c b/drivers/sensor/tdk/icp201xx/icp201xx_drv.c
@@ -216,8 +216,8 @@ static int icp201xx_channel_get(const struct device *dev, enum sensor_channel ch
 {
 	struct icp201xx_data *data = (struct icp201xx_data *)dev->data;
 
-	if (chan != SENSOR_CHAN_AMBIENT_TEMP && chan != SENSOR_CHAN_PRESS &&
-	    chan != SENSOR_CHAN_ALTITUDE) {
+	if (!(chan == SENSOR_CHAN_AMBIENT_TEMP || chan == SENSOR_CHAN_PRESS ||
+	      chan == SENSOR_CHAN_ALTITUDE)) {
 		return -ENOTSUP;
 	}
 	icp201xx_mutex_lock(dev);

Original file line number	Diff line number	Diff line change
`@@ -216,8 +216,8 @@ static int icp201xx_channel_get(const struct device *dev, enum sensor_channel ch`
`216`	`216`	`{`
`217`	`217`	`struct icp201xx_data data = (struct icp201xx_data )dev->data;`
`218`	`218`
`219`		`- if (chan != SENSOR_CHAN_AMBIENT_TEMP && chan != SENSOR_CHAN_PRESS &&`
`220`		`- chan != SENSOR_CHAN_ALTITUDE) {`
	`219`	`+ if (!(chan == SENSOR_CHAN_AMBIENT_TEMP \|\| chan == SENSOR_CHAN_PRESS \|\|`
	`220`	`+ chan == SENSOR_CHAN_ALTITUDE)) {`
`221`	`221`	`return -ENOTSUP;`
`222`	`222`	`}`
`223`	`223`	`icp201xx_mutex_lock(dev);`