build: don't assume .symtab section type

Only the elftools SymbolTableSection section type provides an
iter_symbols() method, and compilers are free to emit sections that
include the substring '.symtab' in their name which causes errors if
gen_relocate_app examines only the section name. Instead check whether a
section is a symbol table to skip attempting to inspect sections that
are not actually symbol tables.

Signed-off-by: Peter Marheine <[email protected]>

Author: tari

scripts/build/gen_relocate_app.py

@@ -41,6 +41,7 @@
 import glob
 import warnings
 from elftools.elf.elffile import ELFFile
+from elftools.elf.sections import SymbolTableSection
 
 # This script will create linker commands for text,rodata data, bss section relocation
 
@@ -180,7 +181,7 @@ def find_sections(filename, full_list_of_sections):
             # common symbols and warns the user of the problem.
             # The solution to which is simply assigning a 0 to
             # bss variable and it will go to the required place.
-            if ".symtab" in section.name:
+            if isinstance(section, SymbolTableSection):
                 symbols = [x for x in section.iter_symbols()]
                 for symbol in symbols:
                     if symbol.entry["st_shndx"] == 'SHN_COMMON':