Skip to content

Commit 3ae685e

Browse files
committed
twister: for ci and in twister.yml, treat built tests as passed
For CI and for the condensed version of the report, consider built tests as passed and do not mark them as skipped. Tests that are built only will be reported as skipped in the full and suite reports. Signed-off-by: Anas Nashif <[email protected]>
1 parent bd1b364 commit 3ae685e

File tree

1 file changed

+6
-5
lines changed

1 file changed

+6
-5
lines changed

scripts/pylib/twister/twisterlib.py

Lines changed: 6 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -3866,7 +3866,7 @@ def process_log(log_file):
38663866

38673867

38683868
@staticmethod
3869-
def xunit_testcase(eleTestsuite, name, classname, status, ts_status, reason, duration, runnable, stats, log):
3869+
def xunit_testcase(eleTestsuite, name, classname, status, ts_status, reason, duration, runnable, stats, log, build_only_as_skip):
38703870
fails, passes, errors, skips = stats
38713871

38723872
if status in ['skipped', 'filtered']:
@@ -3880,6 +3880,7 @@ def xunit_testcase(eleTestsuite, name, classname, status, ts_status, reason, dur
38803880

38813881
if status in ['skipped', 'filtered']:
38823882
skips += 1
3883+
# temporarily add build_only_as_skip to restore existing CI report behaviour
38833884
if ts_status == "passed" and not runnable:
38843885
tc_type = "build"
38853886
else:
@@ -3896,7 +3897,7 @@ def xunit_testcase(eleTestsuite, name, classname, status, ts_status, reason, dur
38963897
if log:
38973898
el.text = log
38983899
elif status == 'passed':
3899-
if not runnable:
3900+
if not runnable and build_only_as_skip:
39003901
ET.SubElement(eleTestcase, 'skipped', type="build", message="built only")
39013902
skips += 1
39023903
else:
@@ -3960,7 +3961,7 @@ def xunit_report_suites(self, json_file, filename):
39603961
classname = ".".join(name.split(".")[:2])
39613962
fails, passes, errors, skips = self.xunit_testcase(eleTestsuite,
39623963
name, classname, status, ts_status, reason, tc_duration, runnable,
3963-
(fails, passes, errors, skips), log)
3964+
(fails, passes, errors, skips), log, True)
39643965

39653966
total = (errors + passes + fails + skips)
39663967

@@ -4036,15 +4037,15 @@ def xunit_report(self, json_file, filename, selected_platform=None, full_report=
40364037
classname = ".".join(name.split(".")[:2])
40374038
fails, passes, errors, skips = self.xunit_testcase(eleTestsuite,
40384039
name, classname, status, ts_status, reason, tc_duration, runnable,
4039-
(fails, passes, errors, skips), log)
4040+
(fails, passes, errors, skips), log, True)
40404041
else:
40414042
reason = ts.get('reason', 'Unknown')
40424043
name = ts.get("name")
40434044
classname = f"{platform}:{name}"
40444045
log = ts.get("log")
40454046
fails, passes, errors, skips = self.xunit_testcase(eleTestsuite,
40464047
name, classname, ts_status, ts_status, reason, duration, runnable,
4047-
(fails, passes, errors, skips), log)
4048+
(fails, passes, errors, skips), log, False)
40484049

40494050
total = (errors + passes + fails + skips)
40504051

0 commit comments

Comments
 (0)