arch: pass struct arch_csf to fatal handlers

ycsin · ycsin · commit 3d5f38f92e4c · 2024-09-05T23:28:51.000+08:00
Change `k_sys_fatal_error_handler()` &amp; `z_fatal_error()` API to
accept an additional `struct arch_csf` argument, which can be helpful
to debug an error.

Signed-off-by: Yong Cong Sin &lt;ycsin@meta.com&gt;
Signed-off-by: Yong Cong Sin &lt;yongcong.sin@gmail.com&gt;
diff --git a/arch/arc/core/fatal.c b/arch/arc/core/fatal.c
@@ -50,7 +50,7 @@ void z_arc_fatal_error(unsigned int reason, const struct arch_esf *esf)
 	}
 #endif /* CONFIG_EXCEPTION_DEBUG */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 }
 
 FUNC_NORETURN void arch_syscall_oops(void *ssf_ptr)
diff --git a/arch/arc/core/irq_manage.c b/arch/arc/core/irq_manage.c
@@ -242,7 +242,7 @@ void z_irq_priority_set(unsigned int irq, unsigned int prio, uint32_t flags)
 void z_irq_spurious(const void *unused)
 {
 	ARG_UNUSED(unused);
-	z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL);
+	z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL, NULL);
 }
 
 #ifdef CONFIG_DYNAMIC_INTERRUPTS
diff --git a/arch/arm/core/fatal.c b/arch/arm/core/fatal.c
@@ -83,7 +83,7 @@ void z_arm_fatal_error(unsigned int reason, const struct arch_esf *esf)
 	}
 #endif
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 }
 
 /**
diff --git a/arch/arm64/core/fatal.c b/arch/arm64/core/fatal.c
@@ -403,7 +403,7 @@ void z_arm64_fatal_error(unsigned int reason, struct arch_esf *esf)
 #endif /* CONFIG_EXCEPTION_STACK_TRACE */
 #endif /* CONFIG_EXCEPTION_DEBUG */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 
 	CODE_UNREACHABLE;
 }
diff --git a/arch/mips/core/fatal.c b/arch/mips/core/fatal.c
@@ -34,7 +34,7 @@ FUNC_NORETURN void z_mips_fatal_error(unsigned int reason,
 		LOG_ERR("BadVA : %08lx\n", esf->badvaddr);
 	}
 #endif /* CONFIG_EXCEPTION_DEBUG */
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 	CODE_UNREACHABLE;
 }
 
diff --git a/arch/nios2/core/fatal.c b/arch/nios2/core/fatal.c
@@ -36,7 +36,7 @@ FUNC_NORETURN void z_nios2_fatal_error(unsigned int reason,
 	}
 #endif /* CONFIG_EXCEPTION_DEBUG */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 	CODE_UNREACHABLE;
 }
 
diff --git a/arch/riscv/core/fatal.c b/arch/riscv/core/fatal.c
@@ -104,7 +104,7 @@ FUNC_NORETURN void z_riscv_fatal_error_csf(unsigned int reason, const struct arc
 	z_riscv_unwind_stack(esf, csf);
 #endif /* CONFIG_EXCEPTION_STACK_TRACE */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, csf);
 	CODE_UNREACHABLE;
 }
 
diff --git a/arch/sparc/core/fatal.c b/arch/sparc/core/fatal.c
@@ -217,6 +217,6 @@ FUNC_NORETURN void z_sparc_fatal_error(unsigned int reason,
 	}
 #endif /* CONFIG_EXCEPTION_DEBUG */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 	CODE_UNREACHABLE;
 }
diff --git a/arch/x86/core/fatal.c b/arch/x86/core/fatal.c
@@ -416,7 +416,7 @@ FUNC_NORETURN void z_x86_fatal_error(unsigned int reason,
 		}
 #endif
 	}
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 	CODE_UNREACHABLE;
 }
 
diff --git a/arch/x86/core/intel64/irq.c b/arch/x86/core/intel64/irq.c
@@ -35,7 +35,7 @@ static const struct device *const vtd = DEVICE_DT_GET_ONE(intel_vt_d);
 static void irq_spurious(const void *arg)
 {
 	LOG_ERR("Spurious interrupt, vector %d\n", (uint32_t)(uint64_t)arg);
-	z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL);
+	z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL, NULL);
 }
 
 void x86_64_irq_init(void)
diff --git a/arch/xtensa/core/fatal.c b/arch/xtensa/core/fatal.c
@@ -106,7 +106,7 @@ void xtensa_fatal_error(unsigned int reason, const struct arch_esf *esf)
 	}
 #endif /* CONFIG_EXCEPTION_DEBUG */
 
-	z_fatal_error(reason, esf);
+	z_fatal_error(reason, esf, NULL);
 }
 
 #if defined(CONFIG_SIMULATOR_XTENSA) || defined(XT_SIMULATOR)
diff --git a/doc/releases/migration-guide-4.0.rst b/doc/releases/migration-guide-4.0.rst
@@ -26,6 +26,9 @@ Kernel
 
 * The named struct ``_callee_saved_t`` is now deprecated. Use ``struct arch_csf`` instead. (:github:`78029`)
 
+* The fatal handling APIs - ``k_sys_fatal_error_handler`` & ``z_fatal_error`` have been updated to accept
+  an additional ``struct arch_csf`` argument. (:github:`78029`)
+
 Boards
 ******
 
diff --git a/include/zephyr/fatal.h b/include/zephyr/fatal.h
@@ -64,8 +64,11 @@ FUNC_NORETURN void k_fatal_halt(unsigned int reason);
  * @param reason The reason for the fatal error
  * @param esf Exception context, with details and partial or full register
  *            state when the error occurred. May in some cases be NULL.
+ * @param csf Callee-saved-registers, with details and partial or full register
+ *            state when the error occurred. May in some cases be NULL.
  */
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf);
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf,
+			       const struct arch_csf *csf);
 
 /**
  * @brief Called by architecture code upon a fatal error.
@@ -80,8 +83,10 @@ void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf);
  * @param reason The reason for the fatal error
  * @param esf Exception context, with details and partial or full register
  *            state when the error occurred. May in some cases be NULL.
+ * @param csf Callee-saved-registers, with details and partial or full register
+ *            state when the error occurred. May in some cases be NULL.
  */
-void z_fatal_error(unsigned int reason, const struct arch_esf *esf);
+void z_fatal_error(unsigned int reason, const struct arch_esf *esf, const struct arch_csf *csf);
 
 /** @} */
 
diff --git a/include/zephyr/kernel.h b/include/zephyr/kernel.h
@@ -6045,7 +6045,7 @@ static inline void k_cpu_atomic_idle(unsigned int key)
  */
 #define z_except_reason(reason) do { \
 		__EXCEPT_LOC();              \
-		z_fatal_error(reason, NULL); \
+		z_fatal_error(reason, NULL, NULL); \
 	} while (false)
 
 #endif /* _ARCH__EXCEPT */
diff --git a/kernel/fatal.c b/kernel/fatal.c
@@ -35,9 +35,10 @@ FUNC_NORETURN __weak void arch_system_halt(unsigned int reason)
 
 /* LCOV_EXCL_START */
 __weak void k_sys_fatal_error_handler(unsigned int reason,
-				      const struct arch_esf *esf)
+				      const struct arch_esf *esf, const struct arch_csf *csf)
 {
 	ARG_UNUSED(esf);
+	ARG_UNUSED(csf);
 
 	LOG_PANIC();
 	LOG_ERR("Halting system");
@@ -82,7 +83,7 @@ FUNC_NORETURN void k_fatal_halt(unsigned int reason)
 }
 /* LCOV_EXCL_STOP */
 
-void z_fatal_error(unsigned int reason, const struct arch_esf *esf)
+void z_fatal_error(unsigned int reason, const struct arch_esf *esf, const struct arch_csf *csf)
 {
 	/* We can't allow this code to be preempted, but don't need to
 	 * synchronize between CPUs, so an arch-layer lock is
@@ -116,7 +117,7 @@ void z_fatal_error(unsigned int reason, const struct arch_esf *esf)
 
 	coredump(reason, esf, thread);
 
-	k_sys_fatal_error_handler(reason, esf);
+	k_sys_fatal_error_handler(reason, esf, csf);
 
 	/* If the system fatal error handler returns, then kill the faulting
 	 * thread; a policy decision was made not to hang the system.
diff --git a/samples/bluetooth/hci_ipc/src/main.c b/samples/bluetooth/hci_ipc/src/main.c
@@ -320,8 +320,11 @@ void bt_ctlr_assert_handle(char *file, uint32_t line)
 #endif /* CONFIG_BT_CTLR_ASSERT_HANDLER */
 
 #if defined(CONFIG_BT_HCI_VS_FATAL_ERROR)
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf,
+			       const struct arch_csf *csf)
 {
+	ARG_UNUSED(csf);
+
 	/* Disable interrupts, this is unrecoverable */
 	(void)irq_lock();
 
diff --git a/samples/subsys/llext/edk/app/src/main.c b/samples/subsys/llext/edk/app/src/main.c
@@ -100,8 +100,11 @@ static void user_function(void *p1, void *p2, void *p3)
 	printk("[app]Thread %p done\n", k_current_get());
 }
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf,
+			       const struct arch_csf *csf)
 {
+	ARG_UNUSED(csf);
+
 	int i;
 
 	printk("[app]Fatal handler! Thread: %p\n", k_current_get());
diff --git a/submanifests/optional.yaml b/submanifests/optional.yaml
@@ -34,7 +34,7 @@ manifest:
       groups:
         - optional
     - name: sof
-      revision: 0e4c4efcaae858036027607e88406d59bd2a31d8
+      revision: pull/49/head
       path: modules/audio/sof
       remote: upstream
       groups:
diff --git a/subsys/testsuite/ztest/src/ztest_error_hook.c b/subsys/testsuite/ztest/src/ztest_error_hook.c
@@ -46,7 +46,8 @@ __weak void ztest_post_fatal_error_hook(unsigned int reason,
 {
 }
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
 	k_tid_t curr_tid = k_current_get();
 	bool valid_fault = (curr_tid == valid_fault_tid) || fault_in_isr;
diff --git a/tests/arch/arm/arm_hardfault_validation/src/arm_hardfault.c b/tests/arch/arm/arm_hardfault_validation/src/arm_hardfault.c
@@ -13,8 +13,12 @@
 
 static volatile int expected_reason = -1;
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	static bool triggered_synchronous_svc;
 
 	TC_PRINT("Caught system error -- reason %d\n", reason);
diff --git a/tests/arch/arm/arm_interrupt/src/arm_interrupt.c b/tests/arch/arm/arm_interrupt/src/arm_interrupt.c
@@ -88,8 +88,11 @@ static int check_esf_matches_expectations(const struct arch_esf *pEsf)
 	return 0;
 }
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pCsf);
+
 	TC_PRINT("Caught system error -- reason %d\n", reason);
 
 	if (expected_reason == -1) {
diff --git a/tests/arch/arm/arm_no_multithreading/src/main.c b/tests/arch/arm/arm_no_multithreading/src/main.c
@@ -36,8 +36,12 @@ void arm_isr_handler(const void *args)
 	test_flag++;
 }
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	printk("Caught system error -- reason %d\n", reason);
 
 	if (expected_reason == -1) {
diff --git a/tests/arch/x86/static_idt/src/main.c b/tests/arch/x86/static_idt/src/main.c
@@ -47,8 +47,12 @@ static volatile int int_handler_executed;
 /* Assume the spurious interrupt handler will execute and abort the task */
 static volatile int spur_handler_aborted_thread = 1;
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *esf,
+			       const struct arch_csf *csf)
 {
+	ARG_UNUSED(esf);
+	ARG_UNUSED(csf);
+
 	if (reason != K_ERR_SPURIOUS_IRQ) {
 		printk("wrong error reason\n");
 		k_fatal_halt(reason);
diff --git a/tests/bluetooth/audio/mocks/src/fatal.c b/tests/bluetooth/audio/mocks/src/fatal.c
@@ -7,7 +7,11 @@
 #include <zephyr/fatal.h>
 #include <zephyr/kernel.h>
 
-void z_fatal_error(unsigned int reason, const struct arch_esf *esf)
+void z_fatal_error(unsigned int reason, const struct arch_esf *esf, const struct arch_csf *csf)
 {
+	ARG_UNUSED(reason);
+	ARG_UNUSED(esf);
+	ARG_UNUSED(csf);
+
 	ztest_test_fail();
 }
diff --git a/tests/drivers/coredump/coredump_api/src/main.c b/tests/drivers/coredump/coredump_api/src/main.c
@@ -32,9 +32,11 @@ static struct coredump_mem_region_node dump_region0 = {
 	.size = sizeof(values_to_dump)
 };
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
 	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
 
 	printk("%s as expected; reason = %u; halting ...\n", __func__, reason);
 
diff --git a/tests/kernel/fatal/exception/src/main.c b/tests/kernel/fatal/exception/src/main.c
@@ -50,8 +50,12 @@ volatile int rv;
 
 static ZTEST_DMEM volatile int expected_reason = -1;
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	TC_PRINT("Caught system error -- reason %d\n", reason);
 
 	if (expected_reason == -1) {
diff --git a/tests/kernel/fatal/message_capture/src/main.c b/tests/kernel/fatal/message_capture/src/main.c
@@ -12,8 +12,12 @@ static volatile int expected_reason = -1;
 
 void z_thread_essential_clear(struct k_thread *thread);
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	printk("Caught system error -- reason %d\n", reason);
 
 	if (expected_reason == -1) {
diff --git a/tests/kernel/fatal/no-multithreading/src/main.c b/tests/kernel/fatal/no-multithreading/src/main.c
@@ -13,8 +13,12 @@
 
 static ZTEST_DMEM volatile int expected_reason = -1;
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	int rv = TC_PASS;
 
 	TC_PRINT("Caught system error -- reason %d\n", reason);
diff --git a/tests/kernel/mem_protect/demand_paging/src/main.c b/tests/kernel/mem_protect/demand_paging/src/main.c
@@ -63,9 +63,12 @@ char *arena;
 __pinned_bss
 static bool expect_fault;
 
-__pinned_func
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+__pinned_func void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+					     const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	printk("Caught system error -- reason %d\n", reason);
 
 	if (expect_fault && reason == 0) {
diff --git a/tests/kernel/mem_protect/mem_map/src/main.c b/tests/kernel/mem_protect/mem_map/src/main.c
@@ -33,8 +33,12 @@ volatile bool expect_fault;
 __pinned_noinit
 static uint8_t __aligned(CONFIG_MMU_PAGE_SIZE) test_page[TEST_PAGE_SZ];
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	printk("Caught system error -- reason %d\n", reason);
 
 	if (expect_fault && reason == 0) {
diff --git a/tests/kernel/mem_protect/mem_protect/src/common.c b/tests/kernel/mem_protect/mem_protect/src/common.c
@@ -8,8 +8,12 @@
 
 ZTEST_BMEM volatile bool valid_fault;
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	printk("Caught system error -- reason %d %d\n", reason, valid_fault);
 	if (valid_fault) {
 		printk("fatal error expected as part of test case\n");
diff --git a/tests/kernel/mem_protect/protection/src/main.c b/tests/kernel/mem_protect/protection/src/main.c
@@ -28,8 +28,12 @@
 
 #define INFO(fmt, ...) printk(fmt, ##__VA_ARGS__)
 
-void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf)
+void k_sys_fatal_error_handler(unsigned int reason, const struct arch_esf *pEsf,
+			       const struct arch_csf *pCsf)
 {
+	ARG_UNUSED(pEsf);
+	ARG_UNUSED(pCsf);
+
 	INFO("Caught system error -- reason %d\n", reason);
 	ztest_test_pass();
 }
diff --git a/tests/kernel/mem_protect/stackprot/src/main.c b/tests/kernel/mem_protect/stackprot/src/main.c
diff --git a/tests/kernel/mem_protect/sys_sem/src/main.c b/tests/kernel/mem_protect/sys_sem/src/main.c
diff --git a/tests/kernel/mem_protect/syscalls/src/main.c b/tests/kernel/mem_protect/syscalls/src/main.c
diff --git a/tests/kernel/mem_protect/userspace/src/main.c b/tests/kernel/mem_protect/userspace/src/main.c
diff --git a/tests/kernel/pipe/pipe/src/test_pipe.c b/tests/kernel/pipe/pipe/src/test_pipe.c
diff --git a/tests/kernel/smp/src/main.c b/tests/kernel/smp/src/main.c
diff --git a/tests/kernel/threads/dynamic_thread/src/main.c b/tests/kernel/threads/dynamic_thread/src/main.c
diff --git a/tests/kernel/threads/dynamic_thread_stack/src/main.c b/tests/kernel/threads/dynamic_thread_stack/src/main.c
diff --git a/tests/kernel/threads/thread_apis/src/test_essential_thread.c b/tests/kernel/threads/thread_apis/src/test_essential_thread.c
diff --git a/tests/lib/mem_blocks/src/main.c b/tests/lib/mem_blocks/src/main.c
diff --git a/tests/subsys/debug/coredump/src/main.c b/tests/subsys/debug/coredump/src/main.c
diff --git a/tests/subsys/debug/coredump_backends/src/main.c b/tests/subsys/debug/coredump_backends/src/main.c

Original file line number	Diff line number	Diff line change
`@@ -50,7 +50,7 @@ void z_arc_fatal_error(unsigned int reason, const struct arch_esf *esf)`
`50`	`50`	`}`
`51`	`51`	`#endif /* CONFIG_EXCEPTION_DEBUG */`
`52`	`52`
`53`		`- z_fatal_error(reason, esf);`
	`53`	`+ z_fatal_error(reason, esf, NULL);`
`54`	`54`	`}`
`55`	`55`
`56`	`56`	`FUNC_NORETURN void arch_syscall_oops(void *ssf_ptr)`
Original file line number	Diff line number	Diff line change
`@@ -242,7 +242,7 @@ void z_irq_priority_set(unsigned int irq, unsigned int prio, uint32_t flags)`
`242`	`242`	`void z_irq_spurious(const void *unused)`
`243`	`243`	`{`
`244`	`244`	`ARG_UNUSED(unused);`
`245`		`- z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL);`
	`245`	`+ z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL, NULL);`
`246`	`246`	`}`
`247`	`247`
`248`	`248`	`#ifdef CONFIG_DYNAMIC_INTERRUPTS`
Original file line number	Diff line number	Diff line change
`@@ -83,7 +83,7 @@ void z_arm_fatal_error(unsigned int reason, const struct arch_esf *esf)`
`83`	`83`	`}`
`84`	`84`	`#endif`
`85`	`85`
`86`		`- z_fatal_error(reason, esf);`
	`86`	`+ z_fatal_error(reason, esf, NULL);`
`87`	`87`	`}`
`88`	`88`
`89`	`89`	`/**`
Original file line number	Diff line number	Diff line change
`@@ -403,7 +403,7 @@ void z_arm64_fatal_error(unsigned int reason, struct arch_esf *esf)`
`403`	`403`	`#endif /* CONFIG_EXCEPTION_STACK_TRACE */`
`404`	`404`	`#endif /* CONFIG_EXCEPTION_DEBUG */`
`405`	`405`
`406`		`- z_fatal_error(reason, esf);`
	`406`	`+ z_fatal_error(reason, esf, NULL);`
`407`	`407`
`408`	`408`	`CODE_UNREACHABLE;`
`409`	`409`	`}`
Original file line number	Diff line number	Diff line change
`@@ -34,7 +34,7 @@ FUNC_NORETURN void z_mips_fatal_error(unsigned int reason,`
`34`	`34`	`LOG_ERR("BadVA : %08lx\n", esf->badvaddr);`
`35`	`35`	`}`
`36`	`36`	`#endif /* CONFIG_EXCEPTION_DEBUG */`
`37`		`- z_fatal_error(reason, esf);`
	`37`	`+ z_fatal_error(reason, esf, NULL);`
`38`	`38`	`CODE_UNREACHABLE;`
`39`	`39`	`}`
`40`	`40`
Original file line number	Diff line number	Diff line change
`@@ -36,7 +36,7 @@ FUNC_NORETURN void z_nios2_fatal_error(unsigned int reason,`
`36`	`36`	`}`
`37`	`37`	`#endif /* CONFIG_EXCEPTION_DEBUG */`
`38`	`38`
`39`		`- z_fatal_error(reason, esf);`
	`39`	`+ z_fatal_error(reason, esf, NULL);`
`40`	`40`	`CODE_UNREACHABLE;`
`41`	`41`	`}`
`42`	`42`
Original file line number	Diff line number	Diff line change
`@@ -104,7 +104,7 @@ FUNC_NORETURN void z_riscv_fatal_error_csf(unsigned int reason, const struct arc`
`104`	`104`	`z_riscv_unwind_stack(esf, csf);`
`105`	`105`	`#endif /* CONFIG_EXCEPTION_STACK_TRACE */`
`106`	`106`
`107`		`- z_fatal_error(reason, esf);`
	`107`	`+ z_fatal_error(reason, esf, csf);`
`108`	`108`	`CODE_UNREACHABLE;`
`109`	`109`	`}`
`110`	`110`
Original file line number	Diff line number	Diff line change
`@@ -217,6 +217,6 @@ FUNC_NORETURN void z_sparc_fatal_error(unsigned int reason,`
`217`	`217`	`}`
`218`	`218`	`#endif /* CONFIG_EXCEPTION_DEBUG */`
`219`	`219`
`220`		`- z_fatal_error(reason, esf);`
	`220`	`+ z_fatal_error(reason, esf, NULL);`
`221`	`221`	`CODE_UNREACHABLE;`
`222`	`222`	`}`
Original file line number	Diff line number	Diff line change
`@@ -416,7 +416,7 @@ FUNC_NORETURN void z_x86_fatal_error(unsigned int reason,`
`416`	`416`	`}`
`417`	`417`	`#endif`
`418`	`418`	`}`
`419`		`- z_fatal_error(reason, esf);`
	`419`	`+ z_fatal_error(reason, esf, NULL);`
`420`	`420`	`CODE_UNREACHABLE;`
`421`	`421`	`}`
`422`	`422`
Original file line number	Diff line number	Diff line change
`@@ -35,7 +35,7 @@ static const struct device *const vtd = DEVICE_DT_GET_ONE(intel_vt_d);`
`35`	`35`	`static void irq_spurious(const void *arg)`
`36`	`36`	`{`
`37`	`37`	`LOG_ERR("Spurious interrupt, vector %d\n", (uint32_t)(uint64_t)arg);`
`38`		`- z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL);`
	`38`	`+ z_fatal_error(K_ERR_SPURIOUS_IRQ, NULL, NULL);`
`39`	`39`	`}`
`40`	`40`
`41`	`41`	`void x86_64_irq_init(void)`