net: tcp2: Avoid double free message

If there is an error, the net_context.c:context_sendto() will
free the net_pkt, so we must not do it here.

This commit fixes this error message:

<err> net_pkt: *** ERROR *** pkt 0x20421908 is freed already
                                     (context_sendto():1672)

Signed-off-by: Jukka Rissanen <[email protected]>

Author: jukkar

subsys/net/ip/tcp2.c

@@ -1414,7 +1414,6 @@ int net_tcp_queue_data(struct net_context *context, struct net_pkt *pkt)
 	NET_DBG("conn: %p Queued %zu bytes (total %zu)", conn, len,
 		conn->send_data_total);
 	pkt->buffer = NULL;
-	tcp_pkt_unref(pkt);
 
 	ret = tcp_send_queued_data(conn);
 	if (ret < 0 && ret != -ENOBUFS) {
@@ -1435,6 +1434,11 @@ int net_tcp_queue_data(struct net_context *context, struct net_pkt *pkt)
 			pkt->buffer = conn->send_data->buffer;
 			conn->send_data->buffer = NULL;
 		}
+	} else {
+		/* We should not free the pkt if there was an error. It will be
+		 * freed in net_context.c:context_sendto()
+		 */
+		tcp_pkt_unref(pkt);
 	}
 out:
 	k_mutex_unlock(&conn->lock);