tests: Bluetooth: CAP: Add verification of CAP unicast start callbacks

Add verification of the CAP Unicast Audio Start callback parameters.
There was a missing part in the BAP Unicast Client mock that did not
set the ISO state correctly, which caused the procedures to fail, but
without the verification that was not caught.

Signed-off-by: Emil Gydesen <[email protected]>

Author: Thalley

tests/bluetooth/audio/cap_initiator/src/test_unicast_start.c

@@ -1,7 +1,7 @@
 /* test_unicast_start.c - unit test for unicast start procedure */
 
 /*
- * Copyright (c) 2024 Nordic Semiconductor ASA
+ * Copyright (c) 2024-2025 Nordic Semiconductor ASA
  *
  * SPDX-License-Identifier: Apache-2.0
  */
@@ -23,6 +23,7 @@
 #include <sys/errno.h>
 
 #include "bap_endpoint.h"
+#include "bap_iso.h"
 #include "cap_initiator.h"
 #include "conn.h"
 #include "expects_util.h"
@@ -33,6 +34,7 @@
 struct cap_initiator_test_unicast_start_fixture {
 	struct bt_cap_stream cap_streams[CONFIG_BT_BAP_UNICAST_CLIENT_GROUP_STREAM_COUNT];
 	struct bt_bap_ep eps[CONFIG_BT_BAP_UNICAST_CLIENT_GROUP_STREAM_COUNT];
+	struct bt_bap_iso bap_iso[CONFIG_BT_BAP_UNICAST_CLIENT_GROUP_STREAM_COUNT];
 	struct bt_bap_unicast_group unicast_group;
 	struct bt_conn conns[CONFIG_BT_MAX_CONN];
 	struct bt_bap_lc3_preset preset;
@@ -57,6 +59,7 @@ static void cap_initiator_test_unicast_start_fixture_init(
 
 	for (size_t i = 0U; i < ARRAY_SIZE(fixture->eps); i++) {
 		fixture->eps[i].dir = (i & 1) + 1; /* Makes it either 1 or 2 (sink or source)*/
+		fixture->eps[i].iso = &fixture->bap_iso[i];
 	}
 }
 
@@ -129,6 +132,11 @@ static ZTEST_F(cap_initiator_test_unicast_start, test_initiator_unicast_start)
 	zexpect_call_count("bt_cap_initiator_cb.unicast_start_complete_cb", 1,
 			   mock_cap_initiator_unicast_start_complete_cb_fake.call_count);
 
+	zassert_equal(0, mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0], "%d",
+		      mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0]);
+	zassert_equal_ptr(NULL, mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0],
+			  "%p", mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0]);
+
 	for (size_t i = 0U; i < ARRAY_SIZE(stream_params); i++) {
 		const struct bt_bap_stream *bap_stream = &fixture->cap_streams[i].bap_stream;
 		const enum bt_bap_ep_state state = bap_stream->ep->status.state;
@@ -415,6 +423,10 @@ static ZTEST_F(cap_initiator_test_unicast_start,
 
 	zexpect_call_count("bt_cap_initiator_cb.unicast_start_complete_cb", 1,
 			   mock_cap_initiator_unicast_start_complete_cb_fake.call_count);
+	zassert_equal(0, mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0], "%d",
+		      mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0]);
+	zassert_equal_ptr(NULL, mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0],
+			  "%p", mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0]);
 
 	for (size_t i = 0U; i < ARRAY_SIZE(stream_params); i++) {
 		const struct bt_bap_stream *bap_stream = &fixture->cap_streams[i].bap_stream;
@@ -452,6 +464,10 @@ static ZTEST_F(cap_initiator_test_unicast_start, test_initiator_unicast_start_st
 
 	zexpect_call_count("bt_cap_initiator_cb.unicast_start_complete_cb", 1,
 			   mock_cap_initiator_unicast_start_complete_cb_fake.call_count);
+	zassert_equal(0, mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0], "%d",
+		      mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0]);
+	zassert_equal_ptr(NULL, mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0],
+			  "%p", mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0]);
 
 	for (size_t i = 0U; i < ARRAY_SIZE(stream_params); i++) {
 		const struct bt_bap_stream *bap_stream = &fixture->cap_streams[i].bap_stream;
@@ -489,6 +505,10 @@ static ZTEST_F(cap_initiator_test_unicast_start, test_initiator_unicast_start_st
 
 	zexpect_call_count("bt_cap_initiator_cb.unicast_start_complete_cb", 1,
 			   mock_cap_initiator_unicast_start_complete_cb_fake.call_count);
+	zassert_equal(0, mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0], "%d",
+		      mock_cap_initiator_unicast_start_complete_cb_fake.arg0_history[0]);
+	zassert_equal_ptr(NULL, mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0],
+			  "%p", mock_cap_initiator_unicast_start_complete_cb_fake.arg1_history[0]);
 
 	for (size_t i = 0U; i < ARRAY_SIZE(stream_params); i++) {
 		const struct bt_bap_stream *bap_stream = &fixture->cap_streams[i].bap_stream;

tests/bluetooth/audio/cap_initiator/uut/bap_unicast_client.c

@@ -14,6 +14,7 @@
 #include <zephyr/bluetooth/audio/bap.h>
 #include <zephyr/bluetooth/conn.h>
 #include <zephyr/bluetooth/hci_types.h>
+#include <zephyr/bluetooth/iso.h>
 #include <zephyr/sys/printk.h>
 #include <zephyr/sys/slist.h>
 #include <zephyr/ztest_assert.h>
@@ -156,25 +157,30 @@ int bt_bap_unicast_client_metadata(struct bt_bap_stream *stream, const uint8_t m
 
 int bt_bap_unicast_client_connect(struct bt_bap_stream *stream)
 {
+	struct bt_bap_ep *ep;
+
 	if (stream == NULL) {
 		return -EINVAL;
 	}
 
-	switch (stream->ep->status.state) {
+	ep = stream->ep;
+
+	switch (ep->status.state) {
 	case BT_BAP_EP_STATE_QOS_CONFIGURED:
 	case BT_BAP_EP_STATE_ENABLING:
 		break;
 	default:
 		return -EINVAL;
 	}
 
+	ep->iso->chan.state = BT_ISO_STATE_CONNECTED;
 	if (stream->ops != NULL && stream->ops->connected != NULL) {
 		stream->ops->connected(stream);
 	}
 
-	if (stream->ep != NULL && stream->ep->dir == BT_AUDIO_DIR_SINK) {
+	if (ep->dir == BT_AUDIO_DIR_SINK) {
 		/* Mocking that the unicast server automatically starts the stream */
-		stream->ep->status.state = BT_BAP_EP_STATE_STREAMING;
+		ep->status.state = BT_BAP_EP_STATE_STREAMING;
 
 		if (stream->ops != NULL && stream->ops->started != NULL) {
 			stream->ops->started(stream);