Fix: Build_all tests

- Fix assert msg
- Add missing include

Author: ExtremeGTX

samples/subsys/usb/mtp/README.rst

@@ -17,22 +17,19 @@ Zephyr project tree.
 Requirements
 ************
 
-- USB device driver support
-- Storage media with Littlefs/FAT filesystem support
+- USB device driver support.
+- Storage media with Littlefs/FAT filesystem support.
+- Partitions must be mounted before connecting the board to Host.
 
 Building and Running
 ********************
 
-This sample can be built for multiple boards which can support at least one storage parition.
-
-Reel Board
-===========
-
-Build and flash the project:
+This sample can be built for multiple boards which can support at least one storage parition,
+in this example we will build it for the stm32f769i_disco board:
 
 .. zephyr-app-commands::
    :zephyr-app: samples/subsys/usb/mtp
-   :board: reel_board
+   :board: stm32f769i_disco
    :goals: flash
    :compact:
 
@@ -56,13 +53,17 @@ You can then:
 - Browse the device storage
 - Transfer files to/from the device
 - Create/delete directories
-- Manage files on the device
 
 The storage contents will persist across device reboots as long as the
 filesystem is properly unmounted before disconnecting or resetting the device.
 
+.. note::
+
+   Not All MTP Features are implemented, for example you can't move/copy
+   files from within the device, it must be done via Host.
+
 Troubleshooting
-==============
+===============
 
 If the device is not recognized properly:
 

subsys/usb/device_next/class/usbd_mtp.c

@@ -109,7 +109,6 @@ struct net_buf *mtp_buf_alloc(const uint8_t ep)
 	}
 
 	bi = udc_get_buf_info(buf);
-	memset(bi, 0, sizeof(struct udc_buf_info));
 	bi->ep = ep;
 
 #if BUF_TRACE_DEBUG

subsys/usb/device_next/class/usbd_mtp_class.c

@@ -6,6 +6,7 @@
 
 #include <wctype.h>
 #include <stddef.h>
+#include <stdio.h>
 
 #include <zephyr/net_buf.h>
 #include <zephyr/devicetree.h>
@@ -432,7 +433,18 @@ const char *mtp_code_to_string(uint16_t code)
 
 	return str;
 }
+#else
+#define RESET
+#define GREEN
+#define BLUE
+#define MAGENTA
+#define CYAN
+const char *mtp_code_to_string(uint16_t code)
+{
+	return (char*)NULL;
+}
 #endif
+
 int mtp_get_pending_packet(struct mtp_context* ctx, struct net_buf *buf)
 {
 	if (ctx->pending_fn) {
@@ -452,7 +464,7 @@ static void net_buf_add_utf16le(struct net_buf *buf, const char *str)
 	uint16_t len = strlen(str) + 1; /* we need the null terminator */
 
 	for (int i = 0; i < len; i++) {
-		__ASSERT(ascii7_str[i] > 0x1F && ascii7_str[i] < 0x7F,
+		__ASSERT(str[i] > 0x1F && str[i] < 0x7F,
 			 "Only printable ascii-7 characters are allowed in USB "
 			 "string descriptors");
 		net_buf_add_le16(buf, str[i]);
@@ -516,7 +528,7 @@ static int dir_traverse(uint8_t storage_id, const char *root_path, uint32_t pare
 		/* If it's a file, store the path in the array */
 		if (sstorage->files_count < MAX_FILES) {
 			strncpy(sstorage->filelist[sstorage->files_count].name, entry.name,
-				MAX_PATH_LEN - 1);
+				MAX_FILE_NAME - 1);
 			sstorage->filelist[sstorage->files_count].size = entry.size;
 			sstorage->filelist[sstorage->files_count].type =
 				entry.type; /* FS_DIR_ENTRY_FILE=0 or FS_DIR_ENTRY_DIR=1 */

tests/subsys/usb/device_next/build_all.conf

@@ -22,6 +22,8 @@ CONFIG_UART_LINE_CTRL=y
 CONFIG_USBD_CDC_ACM_CLASS=y
 
 CONFIG_USBD_MSC_CLASS=y
+
+CONFIG_FILE_SYSTEM=y
 CONFIG_USBD_MTP_CLASS=y
 
 CONFIG_USBD_AUDIO2_CLASS=y

tests/subsys/usb/device_next/build_all.overlay

@@ -67,6 +67,21 @@
 		};
 	};
 
+	fstab {
+		compatible = "zephyr,fstab";
+		lfs1: lfs1 {
+			compatible = "zephyr,fstab,littlefs";
+			read-size = <32>;
+			prog-size = <32>;
+			cache-size = <256>;
+			lookahead-size = <64>;
+			block-cycles = <512>;
+			partition = <&storage_partition>;
+			mount-point = "/lfs1";
+			automount;
+			mtp-enabled;
+		};
+	};
 };
 
 &zephyr_udc0 {