Skip to content

Commit 3f59cf9

Browse files
decsnynashif
authored andcommitted
drivers: nxp_enet: Fix CID 363724
This addresses the coverity issue ID 363724. This issue seems to have been a false positive, but the root complaint from coverity was that within the callstack of ENET_Up, some functions use the buffer config pointer as an array, whereas in the zephyr driver it is declared as a singleton. Address it by redeclaring this as an array of size 1 instead of a singleton. Signed-off-by: Declan Snyder <[email protected]>
1 parent b05d719 commit 3f59cf9

File tree

1 file changed

+4
-4
lines changed

1 file changed

+4
-4
lines changed

drivers/ethernet/nxp_enet/eth_nxp_enet.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ struct nxp_enet_mac_config {
8484
clock_control_subsys_t clock_subsys;
8585
enum mac_address_source mac_addr_source;
8686
const struct pinctrl_dev_config *pincfg;
87-
enet_buffer_config_t buffer_config;
87+
enet_buffer_config_t buffer_config[1];
8888
uint8_t phy_mode;
8989
void (*irq_config_func)(void);
9090
const struct device *phy_dev;
@@ -737,7 +737,7 @@ static int eth_nxp_enet_init(const struct device *dev)
737737
ENET_Up(data->base,
738738
&data->enet_handle,
739739
&enet_config,
740-
&config->buffer_config,
740+
config->buffer_config,
741741
data->mac_addr,
742742
enet_module_clock_rate);
743743

@@ -955,7 +955,7 @@ BUILD_ASSERT(NXP_ENET_PHY_MODE(DT_DRV_INST(n)) != NXP_ENET_RGMII_MODE || \
955955
.clock_subsys = (void *)DT_CLOCKS_CELL_BY_IDX( \
956956
DT_INST_PARENT(n), 0, name), \
957957
.pincfg = PINCTRL_DT_INST_DEV_CONFIG_GET(n), \
958-
.buffer_config = { \
958+
.buffer_config = {{ \
959959
.rxBdNumber = CONFIG_ETH_NXP_ENET_RX_BUFFERS, \
960960
.txBdNumber = CONFIG_ETH_NXP_ENET_TX_BUFFERS, \
961961
.rxBuffSizeAlign = ETH_NXP_ENET_BUFFER_SIZE, \
@@ -967,7 +967,7 @@ BUILD_ASSERT(NXP_ENET_PHY_MODE(DT_DRV_INST(n)) != NXP_ENET_RGMII_MODE || \
967967
.rxMaintainEnable = driver_cache_maintain, \
968968
.txMaintainEnable = driver_cache_maintain, \
969969
NXP_ENET_FRAMEINFO(n) \
970-
}, \
970+
}}, \
971971
.phy_mode = NXP_ENET_PHY_MODE(DT_DRV_INST(n)), \
972972
.phy_dev = DEVICE_DT_GET(DT_INST_PHANDLE(n, phy_handle)), \
973973
.mdio = DEVICE_DT_GET(DT_INST_PHANDLE(n, nxp_mdio)), \

0 commit comments

Comments
 (0)